You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Hey! Really appreciate the effort! The logic in play_audio_file looks solid, and the fallback to play_alarm() ensures we don’t break existing functionality.
In pyfunny.py, if play_audio_file succeeds but somehow raises an exception after starting playback, we might hear both the custom sound and the default alarm. To be safe, maybe we can add a simple flag or move the play_alarm() call strictly into the except block?
I traced the current CI failure to the workflow setup rather than the custom-sound changes themselves. The Python CI job installs the package with python -m pip install -e ., then immediately runs python -m pytest, so the job fails before exercising the branch because pytest is only in the dev extra.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2
Summary
Testing