[G1] Name of sitting NPC

[cgloeckner]

Hi,

the name of a sitting NPC is drawn at the same height as if the NPC is standing (which afaik differs from vanilla G1).

Here's a screenshot from original G1:

/EDIT: I'll take a look for find a fix for this.

[cgloeckner]

I've found a way to modify the behavior for various kinds of sitting animations (each needs a different height multiplier)

I've created a fork based on the latest master: https://github.com/cgloeckner/OpenGothic/tree/sitting-npc-name
This will probably need more work (adding heights for other animations like plundering etc.) and maybe need a different approach (than adding a bunch of isFoo() methods).

Let me know in which direction I may help.

[Try]

Hi, @cgloeckner !

Today Skeleton::colisionHeight no accounting for any animation transformation, lie sitting. Probably more accurate solution would be to calculate boding box for animation joints and work from it

[cgloeckner]

I took a few tries but with out success.

• Seems like the bounding boxes are passed to the Skeleton by being obtained from the zenkit::ModelHierarchy's pre-calculated bounding boxes. while skeleton construction.
• The MdlVisuals knows attached meshes such like head, but the head mesh's bounding box seems to default, not taking any posture into account. Furthermore when using this, labels are rendered at the feet of the person. Since MeshObjects::Mesh seems not to have a translation pos attribute (for the head) to compensate for, that idea is probably a dead-end.
• I haven't understood the animations system yet, hence I have no idea how to calculate the mesh's position whilst the current animation, hence I cannot recalculate the bounding box.

If you could point me to a good direction, I'd be happy to continue working on a solution to this.

[Try]

Hi,

hence I have no idea how to calculate the mesh's position whilst the current animation, hence I cannot recalculate the bounding box.

Method const Tempest::Matrix4x4& Pose::bone(size_t id) returns world-space matrix for specific bone.
Method MeshObjects::Mesh::bounds - returns bbox of mesh in object-space.

From here, you can combine head.view.bounds() and skInst->bone(head.boneId) to calculate world-space bounds for the head mesh.
To get world-space position of some bone: auto pos3 = {bone.at(3,0),bone.at(3,1),bone.at(3,2)};.

And from here probably loop over attachment and bones and get combined bbox. Also, I don't think zenkit::ModelHierarchy has anything like skinned bbox, for us to use...

[cgloeckner]

Thanks for those tipps. I've found a solution [1] that works fine for NPCs, see below (sorry no audio)

npc.webm

But things look odd with bloodflies, where head.view.isEmpty() (where my implementation defaults to the entire skeleton bbox as before).

bloodfly.webm

I'll need to find a way to reposition the label for regular monsters incl. skeletons (a collapsed skeleton's label remains high up). I assume this is based on the fact, that NPC heads are replaceable (due to the variety of heads available) while e.g. skeleton heads are not.

[1] cgloeckner@ba1032c