Conversation
Owner
|
Hi, @Solessfir ! Thanks for PR, but I will have to reject it for now. There is no software design on save/load in DMA environment yet. One option is to do same as in regular games: stash whole memory state and transparently restore it on load. Other one - make it dirty to respect Ikarus API to work with archives. Either way - it's probably too early to start on it, as first priority would be to have DMA work cleanly in use-cases without save/load. Part of it will include: implement |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loading a save restores script variables but leaves Ikarus's transient parser and engine bindings uninitialized.
Reproduced with Archolos: dialogue and facial-animation calls work in a new game, then fail after saving and reloading with
MEM_GetFuncID: Unresolvable requestand an out-of-bounds access toMOB_CREATEITEMS.PAR1.Call
MEM_InitAllafter restoring variables andHERO, only for scripts using Ikarus. This does not rerun gameplay initialization, reset NPC routines, or change the save format.Verified on Windows using the same save and
AI_ResetFaceAnicall before and after the fix. The call failed before and completed without those errors afterward. Windows and Android ARM64 release builds passed on the development branch before extracting this fix.