Skip to content

Stack subscribe form vertically on mobile to prevent placeholder overflow #152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bst1n wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Stack subscribe form vertically on mobile to prevent placeholder overflow #152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ce6d2d7
Stack subscribe form vertically on mobile to prevent placeholder over…
bst1n Jun 2, 2026
923a554
Address review: scope to members form, preserve classic header bg, re…
bst1n Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion assets/built/screen.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion assets/built/screen.css.map
View file
Open in desktop

Large diffs are not rendered by default.

55 changes: 55 additions & 0 deletions assets/css/screen.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,7 @@ a:hover {
background-color: transparent;
outline: none;
transition: 0.3s ease-in-out;
text-overflow: ellipsis;
}

.gh-form-input::placeholder,
Expand Down Expand Up @@ -362,6 +363,60 @@ body[class*=" gh-font-heading"]:not(.gh-font-heading-fira-sans):not(.gh-font-hea
}
}

/* Stack the subscribe form vertically on narrow viewports so the email
placeholder doesn't get clipped behind the button (an issue that's
especially visible in verbose languages like German or Finnish).
Scoped to form[data-members-form] so the search form (which reuses
.gh-form / .gh-form-input) keeps its single-row layout. */
@media (max-width: 480px) {

@chatgpt-codex-connector chatgpt-codex-connector Bot Jun 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Rebuild the shipped stylesheet

This mobile rule is only added to assets/css/screen.css, but the theme actually preloads and serves {{asset "built/screen.css"}} in default.hbs (lines 11 and 18). I checked assets/built/screen.css and it still lacks the new @media (max-width: 480px) form overrides, so packaged/running themes will keep the old single-row subscribe form and the placeholder clipping remains unfixed until the built CSS is regenerated and committed.

Useful? React with 👍 / 👎.

form[data-members-form].gh-form {
flex-direction: column;
align-items: stretch;
height: auto;
padding: 6px;
border-radius: 28px;
background-color: transparent;
}

form[data-members-form].gh-form:hover {
background-color: transparent;
}

form[data-members-form] .gh-form-input {
position: static;
inset: auto;
width: 100%;
height: 52px;
padding-inline: 22px;
border-radius: 40px;
background-color: var(--color-lighter-gray);
}

.has-light-text form[data-members-form] .gh-form-input,
.gh-footer.has-accent-color form[data-members-form] .gh-form-input {
background-color: rgb(255 255 255 / 0.1);
}

/* Preserve the high-contrast white pill over photography in the
classic header-with-image layout. */
.gh-header.is-classic.has-image form[data-members-form] .gh-form-input {
background-color: #fff;
}

form[data-members-form] .gh-button {
position: static;
right: auto;
width: 100%;
min-width: 0;
margin-top: 10px;
height: 52px;
}

form[data-members-form] > svg {
display: none;
}
}
Comment thread
coderabbitai[bot] marked this conversation as resolved.

/* 5. Layout
/* ---------------------------------------------------------- */

Expand Down