Skip to content

[wip] passing node-notifier options#65

Open
Gvozd wants to merge 1 commit into
masterfrom
64-notifier-options
Open

[wip] passing node-notifier options#65
Gvozd wants to merge 1 commit into
masterfrom
64-notifier-options

Conversation

@Gvozd

@Gvozd Gvozd commented Dec 11, 2020

Copy link
Copy Markdown
Collaborator
  • testing direct passing otpions
  • document it
  • support custom sub-options like
new WebpackNotifierPlugin ({
  notifier: 'NotificationCenter',// or constructor - require('node-notifier').NotificationCenter
  notifierOptions: {
    withFallback: false,
    customPath: undefined
  },
  notifyOptions: {
    appID: 'com.squirrel.your.app'
  }
});

@Gvozd Gvozd changed the title passing node-notifier options [wip] passing node-notifier options Dec 11, 2020
@Nothing-Works

Nothing-Works commented Dec 11, 2020

Copy link
Copy Markdown

@Gvozd maybe just one little thing, I think you should consider user appID as the key rather than appId as appID is matching the exact key from node-notifier. see here

@Gvozd

Gvozd commented Dec 11, 2020

Copy link
Copy Markdown
Collaborator Author

@Nothing-Works Yes, I sealed
of course the appID is correct

corrected the test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants