Skip to content

fix(workspaceindex): import gitsafe under the Twigpine module path - #1153

Merged
kevincodex1 merged 1 commit into
mainfrom
fix/workspaceindex-twigpine-import
Oct 17, 2026
Merged

kevincodex1 merged 1 commit into
mainfrom
fix/workspaceindex-twigpine-import

Conversation

@Vasanthdev2004

@Vasanthdev2004 Vasanthdev2004 commented Oct 17, 2026 •

Copy link
Copy Markdown
Collaborator

What changed

Two import lines in internal/workspaceindex, from github.com/Gitlawb/zero/internal/gitsafe to github.com/Twigpine/zero/internal/gitsafe.

Why

#1149 was opened before #1105 moved the module path, and it was merged a minute after #1105, so its two imports of internal/gitsafe still used the old path. Nothing provides github.com/Gitlawb/zero any more, so main doesn't build at 2ffe183:

internal/workspaceindex/gitignore.go:10:2: no required module provides package github.com/Gitlawb/zero/internal/gitsafe

Every CI job on that commit failed. No other Go file on main imports the old path.

Verification

On Windows, at this branch:

  • go build ./..., go vet ./..., gofmt and git diff HEAD --check are clean.
  • go test ./... passes.
  • go run ./cmd/zero-release build and smoke pass.
  • govulncheck ./... reports no vulnerabilities.

Summary by CodeRabbit

  • Chores
    • Updated internal workspace references. There are no changes to user-facing functionality.

#1149 was opened before #1105 moved the module to github.com/Twigpine/zero
and merged right after it, so its two imports of internal/gitsafe still
used the old path. Nothing provides github.com/Gitlawb/zero any more, so
main stopped building at 2ffe183.
@Vasanthdev2004

Copy link
Copy Markdown
Collaborator Author

@kevincodex1 main hasn't built since #1149 went in right after #1105; every CI job on 2ffe183 failed. This is the two-line fix. lhk0504's #1152 carries the same change in d8a6f71, so whichever lands first, the other merges cleanly.

@coderabbitai

coderabbitai Bot commented Oct 17, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: Twigpine/zero/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 0436b344-9fdc-432c-a62b-b2763dc521ed
📥 Commits

Reviewing files that changed from the base of the PR and between 2ffe183 and 1b220a3.

📒 Files selected for processing: 2
  • internal/workspaceindex/gitignore.go
  • internal/workspaceindex/gitignore_test.go

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

Walkthrough

The gitsafe imports in the workspace index implementation and test now use the Twigpine module path.

Changes

Workspace index imports

Layer / File(s) Summary
Update implementation and test imports
internal/workspaceindex/gitignore.go, internal/workspaceindex/gitignore_test.go
Both gitsafe import paths now use the Twigpine module path.

Priority: ➖ Normal

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Bug fix

Suggested reviewers: fabioleitao

Merge Risk: ⚪ Minimal · up to 1b220

The corrected imports match the repository module path, with no remaining actionable merge risk identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: updating the workspaceindex gitsafe import to use the Twigpine module path.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 2 files.

✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Zero automated PR review

Verdict: No blockers found

Blockers

  • None found.

Validation

  • [pass] Diff hygiene: git diff --check
  • [pass] Tests: go test ./...
  • [pass] Build: go run ./cmd/zero-release build
  • [pass] Smoke build: go run ./cmd/zero-release smoke

Scope

Head: 1b220a37d26d
Changed files (2): internal/workspaceindex/gitignore.go, internal/workspaceindex/gitignore_test.go

This deterministic review checks validation status and basic diff hygiene. A human reviewer still owns product judgment and design quality.

Vasanthdev2004 added a commit that referenced this pull request Oct 17, 2026
main moved the module to github.com/Twigpine/zero in #1105. Rename this
branch's imports to match, including the two in internal/workspaceindex
that main itself still carries until #1153 lands.
Vasanthdev2004 added a commit that referenced this pull request Oct 17, 2026
main moved the module to github.com/Twigpine/zero in #1105. Rename this
branch's imports to match, including the two in internal/workspaceindex
that main itself still carries until #1153 lands.
Vasanthdev2004 added a commit that referenced this pull request Oct 17, 2026
main moved the module to github.com/Twigpine/zero in #1105. Rename this
branch's imports to match, including the two in internal/workspaceindex
that main itself still carries until #1153 lands.
@Vasanthdev2004

Copy link
Copy Markdown
Collaborator Author

@kevincodex1 one more thing, so this doesn't repeat. 18 other open PRs still add imports with the old path, and 12 of them carry approvals: #685, #796, #882, #892, #893, #894, #895, #897, #941, #953, #987 and #993. None of them builds on current main until main is merged in and those imports are renamed, and their green checks won't show it, because nothing makes a PR re-run CI against current main before it merges. Required status checks with "require branches to be up to date before merging" in the main ruleset would. I'm letting the authors of the approved ones know, and my own PRs are getting the same update.

Vasanthdev2004 added a commit that referenced this pull request Oct 17, 2026
main moved the module to github.com/Twigpine/zero in #1105. Rename this
branch's imports to match, including the two in internal/workspaceindex
that main itself still carries until #1153 lands.
Vasanthdev2004 added a commit that referenced this pull request Oct 17, 2026
main moved the module to github.com/Twigpine/zero in #1105. Rename this
branch's imports to match, including the two in internal/workspaceindex
that main itself still carries until #1153 lands.
Vasanthdev2004 added a commit that referenced this pull request Oct 17, 2026
main moved the module to github.com/Twigpine/zero in #1105. Rename this
branch's imports to match, including the two in internal/workspaceindex
that main itself still carries until #1153 lands.

@kevincodex1 kevincodex1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevincodex1
kevincodex1 merged commit ef4da13 into main Oct 17, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants