Repository navigation
fix(workspaceindex): import gitsafe under the Twigpine module path - #1153
Conversation
Zero automated PR reviewVerdict: No blockers found Blockers
Validation
ScopeHead: This deterministic review checks validation status and basic diff hygiene. A human reviewer still owns product judgment and design quality. |
|
@kevincodex1 one more thing, so this doesn't repeat. 18 other open PRs still add imports with the old path, and 12 of them carry approvals: #685, #796, #882, #892, #893, #894, #895, #897, #941, #953, #987 and #993. None of them builds on current main until main is merged in and those imports are renamed, and their green checks won't show it, because nothing makes a PR re-run CI against current main before it merges. Required status checks with "require branches to be up to date before merging" in the main ruleset would. I'm letting the authors of the approved ones know, and my own PRs are getting the same update. |
What changed
Two import lines in
internal/workspaceindex, fromgithub.com/Gitlawb/zero/internal/gitsafetogithub.com/Twigpine/zero/internal/gitsafe.Why
#1149 was opened before #1105 moved the module path, and it was merged a minute after #1105, so its two imports of
internal/gitsafestill used the old path. Nothing providesgithub.com/Gitlawb/zeroany more, somaindoesn't build at 2ffe183:Every CI job on that commit failed. No other Go file on
mainimports the old path.Verification
On Windows, at this branch:
go build ./...,go vet ./...,gofmtandgit diff HEAD --checkare clean.go test ./...passes.go run ./cmd/zero-release buildandsmokepass.govulncheck ./...reports no vulnerabilities.Summary by CodeRabbit