fix(build): raise the standalone binary budget to 544 KiB - #1046
Merged
Conversation
main is red: the artifact is 513422 bytes against a 512000 limit, crossed by ordinary feature growth (#1037 was merged while this check was failing, and every PR opened since inherits the red). Contrary to the issue's first guess, CI does run this check — build.yml installs shfmt and both runners ship jq — so the gate worked and was merged past. The gate is fine; the number was stale. Raising rather than shrinking, because the alternatives are worse: stripping blank lines saves 3244 bytes (still over) and is unsafe, since a blank line inside a heredoc is content — the hazard #990 already had to handle; and shfmt --minify reaches the old line only by stripping all indentation out of the shipped artifact. The reasoning and the measurements are recorded next to the assertion so the next raise is a decision rather than a silencing. Closes #1045
This was referenced Aug 10, 2026
fix(build): the standalone binary is over its 500 KiB budget on main, and CI does not catch it
#1045
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 Background
Related #1045
mainis currently red. The standalone artifact is 513,422 bytes against a 512,000 limit. #1037 was merged whileBuild & Verifywas failing on it, so every PR opened since inherits the red — including #1044.💡 Changes
Why raise rather than shrink
shfmt --minifyBlank-line stripping does not even get under the old line, so the real choice was minify-or-raise. Minifying trades away artifact readability permanently to buy back 0.3%; the growth here is ordinary feature accretion, not a builder regression.
Correcting the issue's premise
#1045 guessed that CI skipped this check. It does not —
build.ymlinstallsshfmtviago installand both runners shipjq, so the test runs. The gate worked and was merged past. Nothing to fix in the workflow.