Skip to content

fix(build): raise the standalone binary budget to 544 KiB - #1046

Merged
Chemaclass merged 1 commit into
mainfrom
fix/1045-binary-size-budget
Aug 10, 2026
Merged

fix(build): raise the standalone binary budget to 544 KiB#1046
Chemaclass merged 1 commit into
mainfrom
fix/1045-binary-size-budget

Conversation

@Chemaclass

Copy link
Copy Markdown
Member

🤔 Background

Related #1045

main is currently red. The standalone artifact is 513,422 bytes against a 512,000 limit. #1037 was merged while Build & Verify was failing on it, so every PR opened since inherits the red — including #1044.

💡 Changes

  • Raise the budget to 557,056 bytes (544 KiB) and record the measurements and reasoning next to the assertion, so the next raise is a decision rather than a silencing
  • Rename the test to match its number

Why raise rather than shrink

approach bytes verdict
as-is 518,493 over
strip blank lines 515,249 still over — and unsafe, a blank line inside a heredoc is content (the hazard #990 had to handle)
shfmt --minify 471,673 reaches it, by stripping every bit of indentation out of the shipped artifact

Blank-line stripping does not even get under the old line, so the real choice was minify-or-raise. Minifying trades away artifact readability permanently to buy back 0.3%; the growth here is ordinary feature accretion, not a builder regression.

Correcting the issue's premise

#1045 guessed that CI skipped this check. It does not — build.yml installs shfmt via go install and both runners ship jq, so the test runs. The gate worked and was merged past. Nothing to fix in the workflow.

main is red: the artifact is 513422 bytes against a 512000 limit, crossed by
ordinary feature growth (#1037 was merged while this check was failing, and
every PR opened since inherits the red).

Contrary to the issue's first guess, CI does run this check — build.yml
installs shfmt and both runners ship jq — so the gate worked and was merged
past. The gate is fine; the number was stale.

Raising rather than shrinking, because the alternatives are worse: stripping
blank lines saves 3244 bytes (still over) and is unsafe, since a blank line
inside a heredoc is content — the hazard #990 already had to handle; and
shfmt --minify reaches the old line only by stripping all indentation out of
the shipped artifact.

The reasoning and the measurements are recorded next to the assertion so the
next raise is a decision rather than a silencing.

Closes #1045
@Chemaclass Chemaclass added the bug Something isn't working label Aug 10, 2026
@Chemaclass Chemaclass self-assigned this Aug 10, 2026
@Chemaclass
Chemaclass merged commit ca413b7 into main Aug 10, 2026
37 checks passed
@Chemaclass
Chemaclass deleted the fix/1045-binary-size-budget branch August 10, 2026 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant