Localization - #31
Merged
Merged
Conversation
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
# Conflicts: # .github/workflows/run_tests.yaml # pyproject.toml # tests/test_solcast_query.py # uv.lock
joshuaRiefman
requested review from
MarwanStar and
jonahjlee
and removed request for
MarwanStar
April 11, 2026 21:24
This comment was marked as low quality.
This comment was marked as low quality.
Sorry, something went wrong.
jonahjlee
approved these changes
Jun 6, 2026
| from .spatial_localization import SpatialLocalization | ||
| from .versioned_table import VersionedTable | ||
| from .localization import Localization | ||
| import pathlib |
Contributor
There was a problem hiding this comment.
I appreciate the imports neatly ordered by line length
| import pathlib | ||
|
|
||
|
|
||
| class Localization(ABC): |
Contributor
There was a problem hiding this comment.
It would be nice to have a brief docstring describing the purpose of the class. Same goes for the other new classes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FEAT: Standardized Localization of Signal Names, Timezone Shifts, and Track Coordinates
What's New
TemporalLocalization,LanguageLocalization, andSpatialLocalizationobjects to help in reducing guesswork when querying and working with data.TemporalLocalizationautomatically handles any timezone shift errors from querying from InfluxDB.LanguageLocalizationhandles the names of signals changing over time and standardizes them to aCanonicalName.SpatialLocalizationkeeps track of list of coordinates to use for any position-based analysis.Deprecated/Removed
poetryhas been completed removed and replaced withuv.Dependencies
poetryhas been completed removed.Notes
DBClienthas been renamed back toInfluxDBClient.InfluxDBClientnow accepts atimeoutparameter which controls the timeout in seconds for a query.*_localization.tomlfile in thelocalization/module folder.solcasthave been marked with asolcasttag. Similarly, tests relying on access to the Tailnet have had askip_cimark. This allows for skipping of the tests in certain conditions where the API they test cannot be accessed.