Skip to content

fix(ui5-date-range-picker): remove only portrait mode on calendars when two months are shown#13703

Open
GDamyanov wants to merge 5 commits into
mainfrom
calendar-two-months-fix
Open

fix(ui5-date-range-picker): remove only portrait mode on calendars when two months are shown#13703
GDamyanov wants to merge 5 commits into
mainfrom
calendar-two-months-fix

Conversation

@GDamyanov

@GDamyanov GDamyanov commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Fixes two-month Calendar behavior by using orientation (_portraitView) only for header/button layout decisions, instead of mixing in compact density logic.

What was changed

  • Removed compact mode dependency from two-month layout checks in Calendar.ts.
  • Updated multi-month header rendering conditions in CalendarTemplate.tsx.
  • Updated next-button visibility logic in CalendarHeaderTemplate.tsx.
  • Improved popup viewport behavior in Calendar.css by adding:
    • overflow: auto;
    • max-height: calc(100vh - 3rem);

Result

  • Correct header and navigation behavior in two-month mode.
  • Consistent behavior across cozy and compact densities.
  • Better usability in smaller viewports (prevents clipping by allowing scroll).

@GDamyanov GDamyanov marked this pull request as draft June 17, 2026 16:22
@GDamyanov GDamyanov temporarily deployed to netlify-preview June 17, 2026 16:22 — with GitHub Actions Inactive
@sap-ui5-webcomponents-release

sap-ui5-webcomponents-release Bot commented Jun 17, 2026

Copy link
Copy Markdown

@hinzzx hinzzx temporarily deployed to netlify-preview June 18, 2026 12:22 — with GitHub Actions Inactive
@GDamyanov GDamyanov temporarily deployed to netlify-preview June 24, 2026 18:05 — with GitHub Actions Inactive
@GDamyanov GDamyanov self-assigned this Jun 24, 2026
@GDamyanov GDamyanov marked this pull request as ready for review June 24, 2026 18:08
@GDamyanov GDamyanov deployed to netlify-preview June 24, 2026 18:12 — with GitHub Actions Active
@GDamyanov GDamyanov temporarily deployed to netlify-preview June 24, 2026 18:12 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants