fix(ui5-shellbar): ignore non-ShellBarItem children in overflow calculation (2.23)#13733
Open
dobrinyonkov wants to merge 1 commit into
Open
fix(ui5-shellbar): ignore non-ShellBarItem children in overflow calculation (2.23)#13733dobrinyonkov wants to merge 1 commit into
dobrinyonkov wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Downport of #13729 to the 2.23.x line.
Original commit on
main: 064fda6Why
The ShellBar overflow calculation currently treats any element slotted under
itemsas an overflowableShellBarItem, which breaks when consumers slot non-ShellBarItemchildren (e.g. for layout or grouping).Customers on the 2.23.x line need the fix without waiting for the next minor.
How
Cherry-picked verbatim from
mainontorelease-2.23.1— no conflicts. Touches:packages/fiori/src/ShellBar.ts— filter overflow candidates to actual ShellBarItemspackages/fiori/src/ShellBarItem.ts— marker on the item class for the filterpackages/fiori/src/ShellBarTemplate.tsx— template adjustmentpackages/fiori/cypress/specs/ShellBar.cy.tsx— covers the non-ShellBarItem child case