CDA-74 Created ADR for timeseries csv formatting#1634
Merged
Conversation
Contributor
MikeNeilson
previously requested changes
Mar 12, 2026
krowvin
reviewed
Mar 12, 2026
Collaborator
There was a problem hiding this comment.
See if you can improve the formatting of the numbering and add more sub section headers to break things up
i.e.
1) vs 1.
Might help in reading this visually when it is rendered!
Optional fix, not a blocker for me.
Collaborator
Author
|
Updated formatting to be more readable. |
rma-bryson
force-pushed
the
feature/CDA-74-ADR-for-TimeSeries-CSV
branch
from
590a37c to
4581866
Compare
MikeNeilson
reviewed
Mar 18, 2026
Contributor
MikeNeilson
left a comment
MikeNeilson
left a comment
There was a problem hiding this comment.
Looks reasonable to me.
Will let @krowvin give the final approval.
adamkorynta
requested changes
Mar 23, 2026
MikeNeilson
reviewed
Mar 30, 2026
adamkorynta
requested changes
Mar 31, 2026
adamkorynta
reviewed
Apr 1, 2026
adamkorynta
reviewed
Apr 1, 2026
adamkorynta
reviewed
Apr 1, 2026
adamkorynta
reviewed
Apr 1, 2026
Closed
Co-authored-by: Mike Neilson <michael.a.neilson@usace.army.mil>
…, it breaks the standard of column to field naming used by jackson.
Co-authored-by: Adam Korynta <47677856+adamkorynta@users.noreply.github.com>
…not relying on indices for optional columns
Co-authored-by: Adam Korynta <47677856+adamkorynta@users.noreply.github.com>
Co-authored-by: Adam Korynta <47677856+adamkorynta@users.noreply.github.com>
Co-authored-by: Adam Korynta <47677856+adamkorynta@users.noreply.github.com>
…record definition
…made at this level
Co-authored-by: Adam Korynta <47677856+adamkorynta@users.noreply.github.com>
Co-authored-by: Adam Korynta <47677856+adamkorynta@users.noreply.github.com>
Co-authored-by: Adam Korynta <47677856+adamkorynta@users.noreply.github.com>
MikeNeilson
force-pushed
the
feature/CDA-74-ADR-for-TimeSeries-CSV
branch
from
90815a0 to
36035ea
Compare
MikeNeilson
reviewed
May 1, 2026
Contributor
MikeNeilson
left a comment
MikeNeilson
left a comment
There was a problem hiding this comment.
I think this is a good start. (NOTE: I mean that in since it's complete and we can go with it, but I'm sure we'll have to change something later... e.g. normal software development.)
I did just share this again with the more focus portion of the community of practice, so will give them a day or two to review, otherwise I would've marked approved.
Contributor
|
@jeffsuperglide @rgoss @adamscarberry As y'all have or might work on A2W and likely don't get arbitrary notifications from CDA developement you might be interested and want to comment. We also have #1692 getting worked on so this should eventually replace the existing A2W CSV download. |
adamkorynta
approved these changes
May 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.