location catalog text search support#1640
Conversation
demonstrating usage of: HydrologicEngineeringCenter/cwms-database#123 TODO: - [ ] merge schema update PR - [ ] integration testing - [ ] OpenAPI documentation
adamkorynta
changed the title
Screenshot for the location search page. |
|
Quick note
I rebuilt and published a newer version of cwmsjs. Saw this was 2 months ago. Might see in the docs If the method you seek is present now? |
This PR is the one adding that query parameter. Kinda chicken-and-egg. |
MikeNeilson
left a comment
MikeNeilson
left a comment
There was a problem hiding this comment.
Overall looks good. Couple of nitpicks. And one thing that's just confusing me.
zack-rma
left a comment
zack-rma
left a comment
There was a problem hiding this comment.
Some questions and nitpicks
|
@MikeNeilson - looks like the test failures are due to the 26.x RC01 schema still being set to 99.99.99 version.... |
MikeNeilson
left a comment
MikeNeilson
left a comment
There was a problem hiding this comment.
Agreed on the failure, should fail correctly when used.
Probably wouldn't hurt to verify once the updated container for the next-release is made, but that does involve tagging a database release.
4 participants
Fixes: #288
demonstrating usage of: HydrologicEngineeringCenter/cwms-database#123
Adds a test page for location search. Note: needs a newer version of cwmsjs that supports text search catalog parameter (I tested via hotswapping in the debugger).
TODO: