Skip to content

Feature/map#222

Open
willbreitkreutz wants to merge 9 commits into
mainfrom
feature/map
Open

Feature/map#222
willbreitkreutz wants to merge 9 commits into
mainfrom
feature/map

Conversation

@willbreitkreutz
Copy link
Copy Markdown
Contributor

No description provided.

@willbreitkreutz willbreitkreutz marked this pull request as draft August 18, 2025 15:50
@krowvin
Copy link
Copy Markdown
Contributor

krowvin commented Aug 18, 2025

@tracyfraley1 Here's the work @thill02 did for the mapping. Will is going to take a look. Then see if we can get it merged in.

@HenryGeorgist
Copy link
Copy Markdown

any status update on this?

@krowvin krowvin linked an issue Mar 31, 2026 that may be closed by this pull request
@krowvin krowvin marked this pull request as ready for review May 4, 2026 15:51
@krowvin krowvin self-requested a review May 4, 2026 15:51
Copy link
Copy Markdown
Contributor

@krowvin krowvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pulled this down locally

need to make sure we merge in main too and get to 4.0.8

Few issues with react 18 vs 19

And missing nav link updates

Extra console log

Comment thread package.json
"dependencies": {
"@headlessui/react": "^2.2.0",
"@tailwindcss/forms": "^0.5.9",
"@usace/groundwork-geo": "^2.0.4",
Copy link
Copy Markdown
Contributor

@krowvin krowvin May 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I attempted a fresh install on local and saw it can load two React versions and crash the docs app.

It was some error along the lines of
ReactCurrentDispatcher and usace_groundwork-geo.js.

I think we need a PR for @usace/groundwork-geo to make react/react-dom peer deps, or for this app to pin/override React so only one version is installed?

const pageBreadcrumbs = [
{
text: "Documentation",
href: "/docs",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nav links are not using the apps established hash/base URL pattern.

Existing docs nav links use BASE_URL + "#/...", but the new mapping links use absolute paths like /docs/mapping: src/nav-links.js (line 263).

Need to ensure all links have the BASE_URL prepended

({ store }) => {
const props = f.getProperties();

console.log(props);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to remove this line

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Map Components

3 participants