Expose transfers as tools and check them in doctor - #143
Merged
Merged
Conversation
Adds transfer_ls, transfer_put, transfer_get and transfer_status to the deferred pool, so the core surface stays at 33. They register only when some endpoint declares a globus_transfer block: a tool whose only possible answer is "not configured" is still a tool a model can call, so an unconfigured install shows no sign of them, and the coverage check excuses those four names rather than whatever happens to be missing. A refused path returns a result with its reason instead of a traceback, and nothing submits before the paths are checked. doctor gains a transfer check that passes when nothing is configured and fails on a configured transfer that cannot work. Probing it found a real gap: the write root was not readable, so a download of what had just been uploaded would have failed. Somewhere you may put a file is somewhere you may look at one.
rajeeja
added a commit
that referenced
this pull request
Sep 12, 2026
Adds transfer_ls, transfer_put, transfer_get and transfer_status to the deferred pool, so the core surface stays at 33. They register only when some endpoint declares a globus_transfer block: a tool whose only possible answer is "not configured" is still a tool a model can call, so an unconfigured install shows no sign of them, and the coverage check excuses those four names rather than whatever happens to be missing. A refused path returns a result with its reason instead of a traceback, and nothing submits before the paths are checked. doctor gains a transfer check that passes when nothing is configured and fails on a configured transfer that cannot work. Probing it found a real gap: the write root was not readable, so a download of what had just been uploaded would have failed. Somewhere you may put a file is somewhere you may look at one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds transfer_ls, transfer_put, transfer_get and transfer_status to the deferred pool, leaving the core surface at 33; three verbs rather than one dispatcher because a model picks better from schemas that name their own arguments, plus a status tool because the other two return a task_id that nothing could otherwise read back. They register only when some endpoint declares a globus_transfer block, so an install that moves no files shows no sign of them, and the namespace-coverage check excuses exactly those four names rather than whatever happens to be unregistered.
doctorgains a transfer check that passes when nothing is configured and fails on a configured transfer that cannot work, which is how the write root turned out not to be readable — somewhere you may put a file is somewhere you may look at one, fixed here. Reopened against main after #142 auto-closed when its base branch was deleted; suite 1114 passed.