Guided Buying: J3 decision surface (Dana Kim) and workbench polish - #1066
Closed
petervachon wants to merge 75 commits into
Closed
petervachon wants to merge 75 commits into
petervachon wants to merge 75 commits into
Conversation
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
Comment on lines
+223
to
+226
| ([entry]) => { | ||
| if (entry) setToolbarStuck(!entry.isIntersecting); | ||
| }, | ||
| { root, threshold: 0 }, |
| @@ -0,0 +1,70 @@ | |||
| import { motion } from "framer-motion"; | |||
| import type { ReactNode } from "react"; | |||
| import { cn } from "@/lib/utils"; | |||
Experiment → Guided Buying docs page links to a full-screen /guided-buying prototype, rendered in a separate React root to escape the Nextra docs layout. Catalog "Selection" workspace: - scan-row and card layouts (toggle) with a recommendation lead row - product detail overlay, cart peek drawer, full-canvas compare table - filters (brand/category/price/stock) with agent chips and price basis - routable, deep-linkable state (?item / ?compare) and Review & submit stub Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Build out the Guided Buying prototype's front-door flow and the buyer's escalation queue, all scripted/mocked atop the Apollo AI Chat pattern. Buy conversation (catalog/v1): - Intake hero → in-chat Bridge: streamed restatement, then an inferred request envelope (cost center / ship-to / need-by / approver with provenance + edit affordances) and the routing consequence, revealed with a staggered field animation. - Continue to selection → sourcing summary + a results carousel rendered inline in the thread (pick + 2 alternatives, skeleton→reveal), with the pick mirroring the catalog's Picked-for-you treatment. - Add to cart confirms in-chat with amount + approval-limit status and a Review affordance; cart pill pulses on increment. - ConversationProvider drives the shared thread across the Buy hero and the docked rail; catalog cards are fully clickable for details. Workbench (workbench/): the off-catalog fork's escalation queue, adapted from the Invoice Processing layout — list with stat cards + Quote (amber) / Contract (red) chips, and a three-region detail (queue · finding + Approve/Counter/Reject + Autopilot composer · Activity/Details/Line items/Source). Seeded with the standing-desks quote and mobile-lines contract. Actions stubbed. Shared Ai Chat tweaks: hover-only message actions, tighter empty-state composer, stable scrollbar gutter. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…nd finish lines Pull the buy flow back to the intended model — chat as the front door and a tertiary escape hatch, a guided structured middle, and real finish lines. - Intake stays conversational; once a request is made, a guided surface (BuyScaffold + GuidedBuy) presents the envelope/results directly, no transcript - Constant header anchor (title + subtext) with staggered slide transitions, a consistent back control, and reserved bar height so the anchor never shifts - Agentic Bridge edit: per-field pickers with reasons + cost-center→approver cascade; routing line indented to the card; em-dash removed - Cart as a first-class object: persistent cart button (transitions in on Selection), peek with editable quantities, card-level steppers, and a primary "Review & submit · N · $total" that feeds the one unified Review page - Configure + catalog submission finish lines: outcome headline, agent line naming the destination, dynamic recap, single primary exit, no in-flow back - One Autopilot FAB replacing all scattered ask affordances (currently hidden behind a flag), with a persistent context-aware mini-chat thread - Selection product matches shown as a 3-up grid instead of a cut-off carousel - Shell: two demo seats (requester/buyer) with a Switch user menu item - Buy intake composer gains attachment UI; example chips get a "Try an example" label Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…mpt continuity, copy - Bridge → Configure now reads as an expansion (rail reveals from the right, center fades, header anchored) instead of a horizontal swipe - Configure rail cleaned up: sentence case, connecting-line timeline with dashed not-started dots, baseline-aligned header, more title→timeline space - Carry the user's prompt through the flow: a "Request · From you" row on both Bridges (editable free text on catalog, read-only on contract) and the prompt as the Review hero for continuity - Bridge field picker closes with the reverse of its open (a touch quicker); the edit pencil swaps to a check while a field is open - Rebrand "Autopilot" → "AI Assistant" and "Picked for you" → "Best match" in user-facing text (code identifiers unchanged) - Hide the Autopilot FAB behind a flag (kept fully wired for later) - Copy: intake/Bridge/Selection headers + subtext, intake placeholder - Fix: contract finish line "Back to Buy" now resets to a fresh Intake (honors resetChat) instead of returning to the in-flight Bridge Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…cles The not-completed step markers were inline spans, so size-4 didn't apply and they collapsed to a thin vertical sliver. Add block + a 2px ring so they match the completed checkmark circles: solid border for the current step, dotted for upcoming. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ed Buying - Configure timeline dots render as proper circles (checks for done, solid ring current, dotted upcoming) - Configure option cards use the card glow selectable state (glass), keeping the teal selected outline - Match preview cards and both Bridge envelopes use the glass variant - Configure step content staggers in (question, note, options, actions) - Selection "Review & submit" transitions in like the top-bar buttons - Soften the card selectable AI glow opacity (shared card component) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…ests queue Add the third use case (services sourcing / RFQ) and the requester's Requests surface to the Guided Buying prototype. Services sourcing: - Swap the desks chip for "Hire 2 contract designers for the Q3 rebrand"; the services Bridge routes an RFQ to procurement. - Workbench gains REQ-2053 with a vendor shortlist (indicative estimates, agent pick, provenance) and an RFQ-as-primary action that sends to the shortlist. Requests (the requester's seat, mirror of the buyer's Workbench): - Seat-dependent nav: requester sees Requests, buyer sees Workbench; the identity chip swaps both and lands on each seat's queue. - Workbench-style list (stat cards + table); detail is a right-side slide-over panel with the status timeline, an AutopilotIcon lead banner, and state-fit actions (Message procurement / Mark urgent in-flight, Reorder / View order when terminal). Notes and urgent flags surface in the buyer's Workbench. - Submitting a contract or services request lands in its Requests panel; the standalone routed confirmation screen is dissolved. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…at rail Replace gradient circle + AutopilotIcon header with the AiMark (Astroid) icon painted via SVG gradient def, and apply --ai-gradient-text clip to the wordmark. Renames label from "AI Assistant" to "Autopilot" per project brand. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…uided Buying - Add FlowPhaseBar component: horizontal phase indicator with dot/check glyphs, muted connector lines, completed phases clickable as back-nav - Wire CATALOG_PHASES (Details→Choose→Review→Done) and NON_CATALOG_PHASES (Details→Sent) into BuyFlow, Review, and CatalogSubmitted - Fix B1 headline reset: replace didReset ref with __TSR_index-keyed effect so navigating to /buy again from the sidebar always resets to Intake - Add fromReview HistoryState flag; Review's phase bar navigates back to Buy without clearing the conversation (preserves selection state) - B2: extend RequestsContext with submittedRows/submitRequest; CatalogSubmitted registers REQ-2052 on mount so it appears in My Requests immediately - B3: MatchCard title line-clamp-2 with fixed 2-line height for aligned cards - B4: Add-button label unified to "Add N" on all three selection cards - B5: Retire gradient fills — Best match badges and send button replaced with ai-gradient-start/15 soft-tint; glow effects kept at opacity-15 - B6: Date format changed from MM/DD/YYYY to DD MMM YYYY across all request rows - B7: KPI hint copy "still with procurement" → "pending approval or sourcing" - B8: Remove Dashboard from sidebar nav (route and page preserved) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…uying shelf build Add a P1/P2 tier toggle to the Guided Buying prototype for CGA (now) vs V2 (next) feature comparison. Key additions: - TierContext / TierProvider with localStorage persistence - <P1> and <P2> gate components; useTier() only in permitted files - TierToggle segmented control injected into ApolloShell via new headerSlot prop - GB prototype tokens added to globals.css (--gb-tealbg, --gb-tealline, etc.) - J1-01: chip starters copy cleanup (no trailing periods) - J1-02: TeamsResumeCard with teal border, resume to bridge, step name "Picks up at Details" instead of drifting step number - J1-04: AI reasoning strip above match grid, not-picked italic reasons on alt cards, AI pick badge with P1/P2 text swap, teal evidence chips on lead card, action chip row (Why not the XPS?, Compare all three, Ask) - J1-05: P2 personalized strip with provenance chips (lucide icons replacing emoji), Ordered in May chip on lead, Yoga set-aside via setAside prop on MatchCard (unified component, no separate card — prevents layout drift), Update my preferences chip at P2 - KPI grid: auto-fit minmax(200px,1fr) — 3 tiles at P1, 4 at P2, no dead space - Spend under management tile: teal border, +$27,735 delta, P2 only - Chip text raised to 11px minimum Browser-verified at 1440px: KPI grid auto-fit confirmed; Yoga slot height 347px at P1 and P2 (0px delta). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…mit A) Replace ad-hoc ACCENT/gb-teal Button overrides and chip constants with Apollo toolkit primitives across the catalog flow. - MatchCarousel: Card variant="glass" + AiGlow variant="card" for lead card (drops selectable="ai" collision); Badge status="ai" for AI pick badge; Badge variant="secondary" for evidence chips; Badge status="ai" variant="secondary" for memory chips; Button variant="ai-outline" for Ask chip; reasoning strip uses --ai-gradient + --insight-200 border - All 10 catalog files: remove const ACCENT and every className override that applied it; Button default renders bg-primary already - Remove direct bg-(--gb-teal) className from Button in ServiceBridge, ServicesBridge, NotInCatalogBanner, ProductCard Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…tem (Commit B) Replace all --gb-* prototype tokens with canonical Apollo tokens and delete the --gb-* definitions from globals.css. - --gb-teal → --primary across all 14 affected files (spans, borders, rings, backgrounds, text, dot indicators) - --gb-indigo → --insight-600 (TierToggle P2 active state, TeamsResumeCard icon fill) - --gb-indigobg → --insight-50 (TeamsResumeCard icon area background) - WorkbenchDetail timeline dots: amber-500 → --warning, emerald-500 → --success - Delete all 8 --gb-* custom property definitions from app/globals.css Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- MatchCarousel: add AI disclosure line (Info icon + "The output is AI generated. Please review.") below the card grid - MatchCarousel: Yoga card renders identically at both tiers on arrival; set-aside state reserved for stop-3 dock correction (wires in separately) - MatchCarousel: remove "32GB min · saved Jun 12" third provenance chip from j1-05 P2 reasoning strip - ServiceBridge: add AI disclosure line below the interpreted-summary routing line, above the CTA Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…off JourneyBar PM feedback 4 tasks: JourneyBar stage interactivity fix (Received non-button, delivery receipt link), Details button on shelf cards via ProductDetailOverlay, CatalogSubmitted "What happens next" JourneyBar on /track, PO record route at /po/$id with print stylesheet. GROUP 2 cleanup: caveat moved below journey card in RequestWindow (consistent with the other five caveat placements); yogaSetAside state renamed to correctionMade throughout BuyFlow, GuidedBuy, MatchCarousel, ShelfDock. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
… tiles
Removes the P2-gated "Spend under management" tile; hub shows exactly 3 tiles at both
tiers with the auto-fit grid unchanged.
Adds an AI attention line above the tiles, derived from in-flight request data: approver
name and pending-days count parsed from REQUEST_DETAILS, item noun extracted from the
request title. P2 tier appends one inline sentence ("I sent a reminder this morning.")
without altering the P1 sentence. Follow up button routes to /requests/$id at both tiers.
AiCaveat below the attention line at both tiers. Renders nothing if no in-flight request
exists.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Thread userMenuAdditionalItems through ApolloShell → ShellLayout → ShellSidebar → UserProfile → UserProfileMenuItems, replacing the headerSlot TierToggle. TierMenuSection renders two DropdownMenuItems with a Check icon on the active tier, grouped under a "Prototype tier" label. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Avatar background shifts with tier: primary for P1/Now, --insight-600 for P2/Next. Thread avatarClassName through ApolloShell → ShellLayout → ShellSidebar → UserProfile → AvatarFallback. Add colored legend dots (size-2 rounded-full in icon-sized containers) to the tier menu items so they align horizontally with the Toggle theme and Language icons below. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Wrap the 3-up match grid in a -mx-20 breakout div so cards have more horizontal room without widening the surrounding content (reasoning strip, chips, caveat stay at max-w-[720px]). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Back | stepper (absolute center) | Reset+Cart all live in one h-12 band with a hairline border-b. Scroll area moved below the band so the chrome is fixed while content scrolls. phaseBar no longer lives in the anchor div — it sits in the band between the flanking controls. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…oose MatchCarousel now shows the user's original requestText (from useConversation) as a quoted line above the AI reasoning strip — making the human ask visually distinct from AI output. P1 strip shortened: trailing "Here are all three matches so you can see why." removed (already implied by the cards below). Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Each non-lead, non-set-aside MatchCard now gets a "Why not this?" ghost button that opens the ShelfDock scoped to that item (Yoga or XPS). ShelfDock gains a `subject: CatalogItem` prop; defense copy switches between XPS_DEFENSE and YOGA_DEFENSE based on subject.id. "Update my preferences" moves into the P2 reasoning strip (after badge chips). The chip row below the grid is removed; the Ask button moves beside the Review CTA in the bottom row. BuyFlow adds shelfDockSubject state and passes it to ShelfDock. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
INFERRED_REQUEST_QUANTITY corrected from 2 to 15 so "Add N" and cart totals reflect the canonical journey (15 × $1,849 EPP). SAMPLE_REQUEST summary and the Intake CATALOG_STARTER chip updated to match "15 laptops for Fusion Event contractors" — keeps the requestText hero on the Choose screen consistent with the cards. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…bject At P2, the Teams resume card and the AiChatInput now share a single continuous outline: the band provides top+left+right borders (rounded-t-xl, border-2 border-input, insight-50 tint), the form provides left+right+bottom (border-t-0 rounded-b-xl). No gap, no double border at the seam. AiChatInput gains an `embedded` prop that drops the outer pt-3/px-4 padding (aligning left/right borders with the band above), suppresses the glow, and removes the focus box-shadow that would bleed into the band. Corner radius changes between tiers are the deliberate, accepted consequence of attachment. Resume demoted to ghost button — one primary action on the Intake screen. Band background is --insight-50 so it reads as provenance, not a peer card. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Done screen: header chrome, receipt-style summary card, animated confirm check, and reordered action bar with the AI caveat above it - Add consistent step-transition fades across Choose, Review, and Done - Bridge: read-only Request row with a Revise action that reparses the envelope and preserves any fields the user overrode - Fix BuyFlow's reset effect wiping conversation state on navigation to Review/Done, which had silently broken the header title everywhere - Assistant panel: split the Details entry into records vs. guessed fields, with hover tooltips on the pencil/revise icons - Request detail: adopt PageHeader, two-column layout with a sidebar for record metadata and linked records, gated to the P2 tier as before - Split request titles into a short generated title (used as chrome) and the verbatim prompt (shown in full in the sidebar) - Fix the Requests list/detail title mismatch by sourcing both from the same generated title instead of a separately re-derived cart summary Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…tions Request detail: - Merge the agent line and stage bar into one AI-summary lead card: mark + label, a state-aware sentence with the notable fact highlighted via --ai-gradient, and a new ActivityTrack (bigger nodes, pulsing ring on the current stage, event pins for user/agent activity). - Header now only carries a primary action when one is genuinely owed (Confirm receipt when delivered, Respond when sent back); status badge removed since state already reads from the summary and stage track. - Nudge and Mark urgent moved into the lead card as real outline buttons with icons; completed state keeps button chrome (filled-muted, check icon, "today" label) instead of collapsing to plain text. - Reference column de-carded to a plain labelled list, widened to 200px, aligned to the card's first content line, 8px-base vertical rhythm. Requests list: - Add a "delivered" status (wired end-to-end via REQ-2031: row, detail, and close-window data) so Confirm receipt has somewhere real to go. - Row-level Confirm receipt action for delivered rows, plus a hover-reveal overflow menu for copy link / view PO. - Attention line now summarizes count and opens a filtered view when more than one request needs attention, instead of only ever naming one.
… URLs, inline cart editing Delivery receipt: - Remove the standalone Close Window and /close/$id route; a request that reaches "delivered" now shows that state on its own detail page instead of a second page with different header chrome. - "Confirm receipt" opens a modal (ordered qty, quantity-received stepper with live match/short warning, damaged-items checkbox, optional note) instead of committing silently or navigating away. - Confirming plays the Done screen's check animation (extracted to a shared ConfirmCheck), appends a Communication entry, and — when partial or damaged — states that in the summary and on the stage track. - Linked records (PO/PR chips) migrate from the removed page's data into the sidebar, driven by RequestDetail instead of hardcoded JSX. Decision window — notifications and post-approval states: - Replace the persistent "Approved" banner with a Sonner toast per the in-product notification guidelines; add a global Toaster host. - Add a header Status badge + Approved date field so the state change stays visible once the toast dismisses. - Every element gets a distinct approved-state instead of showing pre-decision copy after the fact: AI summary states the outcome (PO sent, expected delivery), budget/device management restate in present tense, the PO chip becomes a real linked record, a confirmation line + "View order" replaces the decision buttons, and the approval itself (with any note left in the composer) appends to Communication. Real URLs: - Switch the TanStack router from memory to browser history with a basepath, add a Next.js catch-all route (split into a literal page.tsx + sibling [...slug] since Nextra's page-map needs a literal file) so reloading or sharing a deep link works instead of 404ing. - Make the Buy flow's Bridge/Selection phases addressable via /buy?phase=..., with instant seeding (bypassing the scripted stream) for deep links and reloads; Review and the Done screen seed the same way when reached with an empty cart. - Fix a stray re-render (router state updates a tick before BuyFlow unmounts on its way to /review) that was silently resetting the conversation, breaking Review's Back button. Review screen — inline cart editing: - Remove "Edit cart" (it navigated away to change a number already on screen); line items become the cart itself — quantity stepper, unit price, remove control, live-recalculating totals. - Add "Add items from the catalog" as a drawer over Review instead of a navigation; removing the last item leaves an empty state with the add link and disables submit, without navigating away. - Fix the cart pricing bug: the drawer, header cart pill, and add-to-cart toast all priced off the browse-time list/EPP filter instead of the fixed EPP price the cart actually charges, so opening the cart could make the same order look like it got more expensive. Bump @tanstack/react-router to 1.170.18 (apollo-vertex only). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…f to Details New /home route: a composer identical to Buy's Intake (same AiChatInput, Teams-resume band, starter chips), plus a tiered "Your requests" list (P1 factual status line, P2 appends an agent-voice line and the AI caveat) with a single uniform stage icon per row. Added above Buy in the sidebar nav and as the app's default landing. Submitting (typed text, Enter, or the laptops chip) seeds the conversation via sendCatalogRequest and navigates to /buy?phase=bridge, so Details' Request row and Need by popover reflect the real typed text instead of the canonical demo default. The other two chips route to a plain /buy — they don't have an addressable Details step yet. AiChatEmptySuggestions gained additive label/value support so chips can show a short label while still submitting the full sentence; Buy's own chips now share the same STARTER_SUGGESTIONS constant. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 115 out of 173 changed files in this pull request and generated 2 comments.
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
apps/apollo-vertex/registry/ai-chat/components/ai-chat-input.tsx:155
sendDisabledonly disables the send button, but sending can still be triggered via Enter (textarea keydown) or form submit, so the gate can be bypassed. IfsendDisabledis meant to block sending, it should also be enforced insubmitMessage.
Comment on lines
+3
to
+10
| import { useEffect, useState } from "react"; | ||
|
|
||
| export type ViewMode = "desktop" | "compact" | "stacked"; | ||
|
|
||
| export function useViewMode( | ||
| ref: React.RefObject<HTMLDivElement | null>, | ||
| ): ViewMode { | ||
| const [mode, setMode] = useState<ViewMode>("desktop"); |
Comment on lines
+8
to
+13
| <a | ||
| href="/guided-buying" | ||
| target="_blank" | ||
| rel="noreferrer" | ||
| className="not-prose inline-flex items-center gap-2 rounded-md bg-primary px-4 py-2 text-sm font-medium text-primary-foreground no-underline transition-colors hover:bg-primary/90" | ||
| > |
…enus Splits the flat persona list into "Journey 1: Catalog" (Marcus, Alex) and "Journey 3: Software" (Priya, Sam, Dana, Elena, Ravi under P2), each its own DropdownMenuSub flyout matching the existing Toggle theme/Language treatment, rather than two labeled but flat sections. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 115 out of 173 changed files in this pull request and generated no new comments.
Suppressed comments (2)
Previously missed (2) — in code that hasn't changed since the last review.
apps/apollo-vertex/registry/ai-chat/components/ai-chat-input.tsx:114
- The
onPendingFilesChangeeffect intentionally omits the callback from its dependency list, which can call a stale handler if a parent re-renders with a new function (and it requires an eslint disable). Including the callback keeps behavior correct and removes the need for the disable.
apps/apollo-vertex/package.json:66 @tanstack/router-coreis pinned to 1.171.17 while@tanstack/react-routerresolves to 1.170.x (see pnpm-lock). Mixing TanStack router package versions can lead to duplicate installs and type incompatibilities (especially sinceRoutePathsis used for type-level route validation). Align the versions to the same release line.
There was a problem hiding this comment.
🔵 Needs a closer look
It introduces at least one type-checking bug (missing React type import) and a few confirmed accessibility/runtime-state issues that should be fixed before merging.
Review details
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
apps/apollo-vertex/registry/shell/shell-user-provider.tsx:66
- When
userOverrideis provided,isLoadingstill comes from the auth hook. That can keep guards likeGroupMembershipGuardin a perpetual “verifying” state even though a usable user is present.
- Files reviewed: 115/173 changed files
- Comments generated: 0 new
- Review effort level: Lite
There was a problem hiding this comment.
🔵 Needs a closer look
There are confirmed accessibility and behavioral issues (unlabeled form fields, truncation logic not updating on resize, and drilldown tab/type drift) that should be addressed before approval.
Review details
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
apps/apollo-vertex/registry/ai-chat/components/ai-chat-input.tsx:114
- This effect intentionally omits
onPendingFilesChangefrom its dependency list, which can lead to stale callbacks if the prop ever changes. Including it removes the need for the eslint disable and keeps the behavior correct.
- Files reviewed: 115/173 changed files
- Comments generated: 0 new
- Review effort level: Lite
There was a problem hiding this comment.
🔵 Needs a closer look
It contains a TypeScript compile issue (React.RefObject used without importing React) and a few confirmed accessibility/state correctness problems that should be addressed before merging.
Review details
Suppressed comments (1)
Previously missed (1) — in code that hasn't changed since the last review.
apps/apollo-vertex/registry/shell/shell.tsx:36
- The
ShellUserinterface uses a field namedemail, but the comment and current usage treat it as a generic subtitle (e.g. a role/seat label). This is misleading for consumers and makes it unclear what should be passed here.
- Files reviewed: 115/173 changed files
- Comments generated: 0 new
- Review effort level: Lite
Update the '15 laptops · Fusion Event' starter chip on the guided buying /home screen to '15 laptops · Contractors', and update the text it autofills into the composer on click to '15 laptops for contractors for an upcoming dev project'. Scoped to just the chip label and /home's autocomplete text; /buy's own copy of the chip, the deep-link default scenario, and the quantity-inference constant still reference the old Fusion Event scenario text, intentionally left untouched. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…sion keynote The Marcus Webb "Choose" step timeline read "3 met the 32GB minimum," a raw count that undersells why laptops were filtered. For the Fusion keynote demo, reword it to "Policy checked: Only showing laptops that meet engineering spec," with "Policy checked:" bolded, so the narrowing reads as a deliberate policy check rather than an arbitrary number. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…ion keynote
Continues the Fusion keynote copy pass: the summary headline now reads as an
engineering-requirements assessment ("Identified that the laptops are for
engineering and assessed engineering laptop requirements to narrow the
search.") instead of citing raw counts and the RAM threshold directly. The
picked-laptop detail line changes from "Picked" to "Suggested" to match the
softer, recommendation-toned voice used elsewhere in the flow, with
"Suggested Lenovo ThinkPad X1 Carbon:" bolded via the existing **bold**
detail-line convention.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
… Fusion keynote
Continues the Fusion keynote copy pass: the lead-card subhead ("Best price
after EPP, and it clears your 32GB minimum.") named the raw RAM threshold
directly. Reworded to "Best price after EPP, and it meets engineering laptop
specs." to match the engineering-specs framing used elsewhere in the flow.
Also updated winningReasonParts, the shared reason-builder behind the
dynamic re-ranked subhead, so both the default and re-ranked states read
consistently.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
angeloaltamiranom
force-pushed
the
GuidedBuying_Journey3
branch
from
September 9, 2026 11:45
14902a1 to
6db3165
Compare
There was a problem hiding this comment.
🟡 Changes recommended
There are confirmed correctness issues (a TypeScript module-scope type reference that can fail builds, a sidebar override tracking bug, an accessibility labeling gap, and mismatched TanStack Router package versions) that should be addressed before approval.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 115/173 changed files
- Comments generated: 2
- Review effort level: Lite
| "@tanstack/react-router": "^1.170.18", | ||
| "@tanstack/react-store": "^0.11.0", | ||
| "@tanstack/react-table": "^8.21.3", | ||
| "@tanstack/router-core": "1.171.17", |
Comment on lines
+63
to
+69
| useEffect(() => { | ||
| sidebarChangeIsOurs.current = true; | ||
| if (openId == null) { | ||
| setSidebarOpen(true); | ||
| } else if (!sidebarOverridden) { | ||
| setSidebarOpen(false); | ||
| } |
Adds deliberate waiting time at three points in the catalog journey so loading no longer reads as instant/faked for the Fusion keynote demo: submit prompt to request envelope (1.5s), confirm to dashboard product cards (3s), and Review's Submit request to the submitted screen (3s). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
There was a problem hiding this comment.
🔵 Needs a closer look
There are confirmed type/runtime correctness issues (missing React type import in useViewMode, a missing “trend” drilldown tab entry, and stale truncation detection) that should be addressed before approval.
Review details
- Files reviewed: 115/173 changed files
- Comments generated: 0 new
- Review effort level: Lite
Contributor
|
This PR has been stale for over 2 weeks with no new commits. Closing — feel free to reopen if you'd like to continue this work. To keep a PR exempt from this automation, add the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This branch carries the Guided Buying prototype's J3 storyline (a second decision-making persona, Dana Kim, alongside the existing requester/buyer/approver personas) through the request → validation → decision flow, plus supporting workbench and requester-surface work built up over the branch's history.
Most recent additions in this push:
Test plan
pnpm lint/pnpm typecheck/pnpm buildclean🤖 Generated with Claude Code