feat(apollo-react): add HITL form interaction concepts - #1125
dbacomputer wants to merge 2 commits into
Conversation
|
Apollo Coded App preview deployments are ready.
|
Dependency License Review
License distribution
Excluded packages
|
There was a problem hiding this comment.
🟡 Changes recommended
It introduces new component behavior without corresponding unit tests and adds unlabeled editable inputs in a Storybook pattern that need basic accessibility naming.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR expands the Form HITL exploration in Storybook by adding a new “Form HITL V2.1” variant with multiple editable Concept fields and alternative control/delete placements, supported by small API extensions to the LockableValueField component in apollo-wind.
Changes:
- Added a new
QuickFormIntrtnStorybook story variant (“Form HITL V2.1”) and updated the concept-row interactions/menus to support placement comparisons. - Extended
LockableValueFieldto support field-level “More” menu children + delete, configurable leading-addon styling, and the ability to hide the value-type (Fixed/Expression) action. - Enhanced the Storybook layout pattern example to support inline editing of node label/category and updated validation messaging.
File summaries
| File | Description |
|---|---|
| packages/apollo-wind/src/components/ui/lockable-value-field/types.ts | Adds new public props for field-level More actions, leading addon styling, and value-type action visibility. |
| packages/apollo-wind/src/components/ui/lockable-value-field/lockable-value-field.tsx | Implements new LockableValueField behaviors (More menu children/delete, leadingAddonClassName, showValueTypeAction). |
| packages/apollo-react/src/canvas/components/NodePropertyPanel/NodePropertyPanel.stories.tsx | Introduces “Form HITL V2.1” exploration story and expands concept-row interaction patterns (drag/delete/menu placements). |
| apps/storybook/src/patterns/LayoutPatterns.stories.tsx | Updates the DAP validation panel demo with editable node metadata and revised alert copy. |
Review details
Suppressed comments (1)
apps/storybook/src/patterns/LayoutPatterns.stories.tsx:431
- The editable node category input has no accessible name. Add an aria-label (or aria-labelledby) so assistive tech can identify what the input is for when switching into edit mode.
<input
- Files reviewed: 4/4 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| nodeLabel={ | ||
| <span className="flex flex-col items-start gap-1"> | ||
| {editingLabel ? ( | ||
| <input |
| export interface LockableValueFieldMoreActions { | ||
| /** Removes the field itself from its parent collection. */ | ||
| onDelete?: () => void; | ||
| /** Additional field-level actions rendered inside the More menu. */ | ||
| children?: ReactNode; | ||
| onClear?: () => void; | ||
| onRefresh?: () => void; | ||
| } |
Storybook visual diffBaseline is the deployed main Storybook, so changes merged to main after this branch was last updated can also appear here. Logs Updated (PT): Sep 04, 2026, 03:28:26 PM |
📊 Coverage + size by packagePer-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.
"Coverage" is each package's own |
Summary
Preview
Verification
git diff --checkpassed.