Skip to content

feat(apollo-react): add HITL form interaction concepts - #1125

Draft
dbacomputer wants to merge 2 commits into
mainfrom
codex/InteractiondesignforHITLForm
Draft

dbacomputer wants to merge 2 commits into
mainfrom
codex/InteractiondesignforHITLForm

Conversation

@dbacomputer

Copy link
Copy Markdown
Collaborator

Summary

  • Add the Form HITL V2.1 Storybook exploration with four editable Concept fields.
  • Demonstrate alternative drag/delete placements across Concepts 1–4.
  • Add More-menu flyouts for value type, field type, required state, AI assist, insert variable, and delete.
  • Extend Lockable Value Field with reusable leading-addon styling and field-level More actions.
  • Keep the original Form HITL story unchanged.

Preview

Verification

  • Biome format/check passed.
  • Apollo React TypeScript check passed.
  • Apollo Wind build passed.
  • git diff --check passed.

Copilot AI lite review requested due to automatic review settings September 4, 2026 22:15
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Apollo Coded App preview deployments are ready.

Project Status Preview Updated (PT)
apollo-design Ready Preview · Logs Sep 04, 2026, 03:22:44 PM
apollo-docs Ready Preview · Logs Sep 04, 2026, 03:22:44 PM
apollo-landing Ready Preview · Logs Sep 04, 2026, 03:22:44 PM
apollo-vertex Ready Preview · Logs Sep 04, 2026, 03:22:44 PM

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Dependency License Review

  • 1937 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 2 package(s) excluded (see details below)
License distribution
License Packages
MIT 1708
ISC 88
Apache-2.0 55
BSD-3-Clause 27
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 4
MIT-0 3
CC0-1.0 3
MIT OR Apache-2.0 2
(MIT OR Apache-2.0) 2
Unlicense 2
LGPL-3.0-or-later 1
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.3.2 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

It introduces new component behavior without corresponding unit tests and adds unlabeled editable inputs in a Storybook pattern that need basic accessibility naming.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR expands the Form HITL exploration in Storybook by adding a new “Form HITL V2.1” variant with multiple editable Concept fields and alternative control/delete placements, supported by small API extensions to the LockableValueField component in apollo-wind.

Changes:

  • Added a new QuickFormIntrtn Storybook story variant (“Form HITL V2.1”) and updated the concept-row interactions/menus to support placement comparisons.
  • Extended LockableValueField to support field-level “More” menu children + delete, configurable leading-addon styling, and the ability to hide the value-type (Fixed/Expression) action.
  • Enhanced the Storybook layout pattern example to support inline editing of node label/category and updated validation messaging.
File summaries
File Description
packages/apollo-wind/src/components/ui/lockable-value-field/types.ts Adds new public props for field-level More actions, leading addon styling, and value-type action visibility.
packages/apollo-wind/src/components/ui/lockable-value-field/lockable-value-field.tsx Implements new LockableValueField behaviors (More menu children/delete, leadingAddonClassName, showValueTypeAction).
packages/apollo-react/src/canvas/components/NodePropertyPanel/NodePropertyPanel.stories.tsx Introduces “Form HITL V2.1” exploration story and expands concept-row interaction patterns (drag/delete/menu placements).
apps/storybook/src/patterns/LayoutPatterns.stories.tsx Updates the DAP validation panel demo with editable node metadata and revised alert copy.
Review details

Suppressed comments (1)

apps/storybook/src/patterns/LayoutPatterns.stories.tsx:431

  • The editable node category input has no accessible name. Add an aria-label (or aria-labelledby) so assistive tech can identify what the input is for when switching into edit mode.
          <input
  • Files reviewed: 4/4 changed files
  • Comments generated: 2
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

nodeLabel={
<span className="flex flex-col items-start gap-1">
{editingLabel ? (
<input
Comment on lines 109 to 116
export interface LockableValueFieldMoreActions {
/** Removes the field itself from its parent collection. */
onDelete?: () => void;
/** Additional field-level actions rendered inside the More menu. */
children?: ReactNode;
onClear?: () => void;
onRefresh?: () => void;
}
@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Storybook visual diff

⚠️ Visual changes detected: 5 changed, 1 added (of 83 compared, 77 unchanged). View report

Baseline is the deployed main Storybook, so changes merged to main after this branch was last updated can also appear here. Logs

Updated (PT): Sep 04, 2026, 03:28:26 PM

@github-actions

github-actions Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

📊 Coverage + size by package

Per-package coverage and bundle size on this PR. New-line coverage = of the source lines this PR adds or changes, the % hit by tests.

Package Coverage New-line coverage Packed (gzip) Unpacked vs main
@uipath/apollo-core 42.01 MB 50.12 MB ±0
@uipath/apollo-react 39.9% 0.0% (0/25) 7.56 MB 29.14 MB +123 B
@uipath/apollo-ui-icons 2.85 MB 6.91 MB ±0
@uipath/apollo-wind 66.3% 60.0% (3/5) 448.0 KB 2.85 MB +354 B
@uipath/ap-chat 85.8% 43.92 MB 56.68 MB ±0

"Coverage" is each package's own coverage.include scope (e.g. apollo-core instruments only scripts/). "Packed"/"Unpacked" come from npm pack --dry-run and only cover built packages — "—" means not measured this run (package not affected / not built). "vs main" is the packed (gzipped) delta against the last successful main build (the package-sizes artifact from the Release workflow); "—" there means no main baseline was available this run. The baseline is main's latest build, not this PR's exact merge-base, so it includes any drift since the branch diverged. Packages with no vitest config are omitted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants