fix(apollo-react): stop the first-run experience clipping its last suggestion - #1155
andrewwan-uipath wants to merge 1 commit into
Conversation
…ggestion [JAR-10042] The first-run experience container combined overflow: auto with an 8px border radius while painting no background or border, so the radius did nothing but round the scroll clip. The block is pinned to the bottom of the message area, so the last suggestion sits flush against that clip and its bottom-left corner was shaved off. Drop the radius; nothing visible depended on it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Apollo Coded App preview deployments are ready.
|
Dependency License Review
License distribution
Excluded packages
|
There was a problem hiding this comment.
🟡 Changes recommended
Add the requested rationale explaining why the radius must remain removed.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Fixes clipping of the last suggestion in the chat first-run experience by removing the rounded scroll clip.
Changes:
- Removes
borderRadiusfromFREContainer.
File summaries
| File | Summary |
|---|---|
packages/apollo-react/src/material/components/ap-chat/components/message/first-run-experience/chat-fre.tsx |
Prevents bottom-corner clipping of the last suggestion. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| @@ -9,7 +9,6 @@ import { AutopilotChatSuggestions } from '../suggestions/chat-suggestions'; | |||
| const FREContainer = styled('div')(() => ({ | |||
| display: 'flex', | |||
| flexDirection: 'column', | |||
📊 Coverage + size by packagePer-package bundle size on this PR (no JS/TS source changes detected under
"Coverage" is each package's own |
Storybook visual diff✅ No visual changes. 234 stories affected by this PR were compared against the deployed main Storybook. Logs Updated (PT): Sep 11, 2026, 02:32:42 PM |
Summary
In the chat's first-run experience (welcome title, description, suggestion chips), the last suggestion's bottom-left corner is visibly shaved off when the suggestions stack against the bottom of the message area. Seen in Flow's debug chat with two stacked suggestions.
Before:

After:

Root cause
FREContainerinchat-fre.tsxcombinedoverflow: 'auto'withborderRadius: BorderRadiusL(8px) while painting no background or border, so the radius had no visible effect except rounding the scroll clip. The container is pinned tobottom: 0, so the last suggestion sits flush against that rounded clip and loses its corner. The radius has been there since the component was written, with no commit explaining it, and nothing visible depends on it: the chips carry their own radius and border.Fix
Remove the radius from
FREContainerand leave a comment so it isn't reintroduced. Smallest change that removes the clip; the alternative (inner bottom padding) would shift spacing for every host and keep a pointless rounded clip.Verification
biome lint: no new findings (293 pre-existing warnings across the package).chat-message-content.test.tsxfails to import a newer@mui/icons-materialicon in my local checkout because the install is stale (see note), unrelated to this change.tsc --noEmitnon-incrementally with and without the change: identical error set (one pre-existingTS2307from the stale install), none in the changed file.Note: my local
pnpm installonmainfails with a 404 for@uipath/uipath-typescript@1.5.5because a user-level.npmrcroutes the@uipathscope to GitHub Packages; CI's install is unaffected. commitlint was run directly on the commit message.🤖 Generated with Claude Code