Skip to content

fix(apollo-react): stop the first-run experience clipping its last suggestion - #1155

Open
andrewwan-uipath wants to merge 1 commit into
mainfrom
fix/chat-fre-last-suggestion-clipped
Open

andrewwan-uipath wants to merge 1 commit into
mainfrom
fix/chat-fre-last-suggestion-clipped

Conversation

@andrewwan-uipath

@andrewwan-uipath andrewwan-uipath commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Summary

In the chat's first-run experience (welcome title, description, suggestion chips), the last suggestion's bottom-left corner is visibly shaved off when the suggestions stack against the bottom of the message area. Seen in Flow's debug chat with two stacked suggestions.

Before:
Screenshot 2026-09-11 at 2 10 00 PM

After:
Screenshot 2026-09-11 at 2 09 41 PM

Root cause

FREContainer in chat-fre.tsx combined overflow: 'auto' with borderRadius: BorderRadiusL (8px) while painting no background or border, so the radius had no visible effect except rounding the scroll clip. The container is pinned to bottom: 0, so the last suggestion sits flush against that rounded clip and loses its corner. The radius has been there since the component was written, with no commit explaining it, and nothing visible depends on it: the chips carry their own radius and border.

Fix

Remove the radius from FREContainer and leave a comment so it isn't reintroduced. Smallest change that removes the clip; the alternative (inner bottom padding) would shift spacing for every host and keep a pointless rounded clip.

Verification

  • biome lint: no new findings (293 pre-existing warnings across the package).
  • ap-chat unit tests: the three loadable files pass; chat-message-content.test.tsx fails to import a newer @mui/icons-material icon in my local checkout because the install is stale (see note), unrelated to this change.
  • tsc --noEmit non-incrementally with and without the change: identical error set (one pre-existing TS2307 from the stale install), none in the changed file.
  • No Storybook visual snapshot covers the first-run experience, so none to update.

Note: my local pnpm install on main fails with a 404 for @uipath/uipath-typescript@1.5.5 because a user-level .npmrc routes the @uipath scope to GitHub Packages; CI's install is unaffected. commitlint was run directly on the commit message.

🤖 Generated with Claude Code

…ggestion [JAR-10042]

The first-run experience container combined overflow: auto with an 8px
border radius while painting no background or border, so the radius did
nothing but round the scroll clip. The block is pinned to the bottom of
the message area, so the last suggestion sits flush against that clip and
its bottom-left corner was shaved off. Drop the radius; nothing visible
depended on it.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Copilot AI lite review requested due to automatic review settings September 11, 2026 21:15
@github-actions

github-actions Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Apollo Coded App preview deployments are ready.

Project Status Preview Updated (PT)
apollo-design Ready Preview · Logs Sep 11, 2026, 02:24:55 PM
apollo-docs Ready Preview · Logs Sep 11, 2026, 02:24:55 PM
apollo-landing Ready Preview · Logs Sep 11, 2026, 02:24:55 PM
apollo-vertex Ready Preview · Logs Sep 11, 2026, 02:24:55 PM

@github-actions

Copy link
Copy Markdown
Contributor

Dependency License Review

  • 1937 package(s) scanned
  • ✅ No license issues found
  • ⚠️ 2 package(s) excluded (see details below)
License distribution
License Packages
MIT 1708
ISC 88
Apache-2.0 55
BSD-3-Clause 27
BSD-2-Clause 23
BlueOak-1.0.0 8
MPL-2.0 4
MIT-0 3
CC0-1.0 3
MIT OR Apache-2.0 2
(MIT OR Apache-2.0) 2
Unlicense 2
LGPL-3.0-or-later 1
Python-2.0 1
CC-BY-4.0 1
(MPL-2.0 OR Apache-2.0) 1
Unknown 1
Artistic-2.0 1
(WTFPL OR MIT) 1
(BSD-2-Clause OR MIT OR Apache-2.0) 1
CC-BY-3.0 1
0BSD 1
(MIT OR CC0-1.0) 1
MIT AND ISC 1
Excluded packages
Package Version License Reason
@img/sharp-libvips-linux-x64 1.3.2 LGPL-3.0-or-later LGPL pre-built binary, not linked
khroma 2.1.0 Unknown MIT per GitHub repo, missing license field in package.json

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Add the requested rationale explaining why the radius must remain removed.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Fixes clipping of the last suggestion in the chat first-run experience by removing the rounded scroll clip.

Changes:

  • Removes borderRadius from FREContainer.
File summaries
File Summary
packages/apollo-react/src/material/components/ap-chat/components/message/first-run-experience/chat-fre.tsx Prevents bottom-corner clipping of the last suggestion.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@@ -9,7 +9,6 @@ import { AutopilotChatSuggestions } from '../suggestions/chat-suggestions';
const FREContainer = styled('div')(() => ({
display: 'flex',
flexDirection: 'column',
@github-actions

Copy link
Copy Markdown
Contributor

📊 Coverage + size by package

Per-package bundle size on this PR (no JS/TS source changes detected under packages/* or web-packages/*).

Package Coverage New-line coverage Packed (gzip) Unpacked vs main
@uipath/apollo-core 42.01 MB 50.12 MB ±0
@uipath/apollo-react 43.7% 7.56 MB 29.14 MB −67 B
@uipath/apollo-ui-icons 2.85 MB 6.91 MB ±0
@uipath/apollo-wind 451.5 KB 2.87 MB +3 B
@uipath/ap-chat 85.8% 43.92 MB 56.68 MB +17 B

"Coverage" is each package's own coverage.include scope (e.g. apollo-core instruments only scripts/). "Packed"/"Unpacked" come from npm pack --dry-run and only cover built packages — "—" means not measured this run (package not affected / not built). "vs main" is the packed (gzipped) delta against the last successful main build (the package-sizes artifact from the Release workflow); "—" there means no main baseline was available this run. The baseline is main's latest build, not this PR's exact merge-base, so it includes any drift since the branch diverged. Packages with no vitest config are omitted.

@github-actions

Copy link
Copy Markdown
Contributor

Storybook visual diff

✅ No visual changes. 234 stories affected by this PR were compared against the deployed main Storybook. Logs

Updated (PT): Sep 11, 2026, 02:32:42 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:apollo-react size:XS 0-9 changed lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants