Open
Conversation
alexandru-petre
left a comment
There was a problem hiding this comment.
Code review of the 5 new coded sample projects. Substantive review surface = the 5 *.cs workflow files + 2 .java sources + README; auto-generated XAML / entry-points.json / .codedworkflows/Connections*.cs were skipped.
Verdict: NEEDS CHANGES.
Highlights (full inline comments below):
- P0 Broken
Console.WriteLineinterpolation in Credentials sample (missing$). - P1
Delay(...)task discarded in Python sample — no actual wait happens. - P1 Python scope uses sync
usinginstead ofawait using, inconsistent with FTP/Java siblings. - P5 Credentials sample logs
Passwordto console — sample teaches the wrong instinct. - P5 Hardcoded FTP credentials with no pointer to credential assets / vault.
- P5 SQL built via
string.Format— sample teaches the canonical SQL-injection pattern. - P2 Namespace mismatches:
DatabaseCodedDemo(folder isCodedDatabaseDemo) and bareJava. - P3 Unused
usingdirectives in every new.csfile (FTP sample still importsUiPath.Excel.*from copy-paste). - P3 Hardcoded JDK 25.0.2.10 / Python 3.13 paths break the sample for everyone except the author.
Positive observations:
- Good
await usingpattern in FTP and Java samples. - Java sources (
Coordinate.java,StaticMethods.java) are clean and appropriately demo-scoped. - README entries follow the existing one-line, alphabetized convention.
Address review findings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added coded sample for Credentials
Added coded sample for Database
Added coded sample for FTP
Added coded sample for Java
Added coded sample for Python