feat: support for IS resume triggers#105
Open
GabrielVasilescu04 wants to merge 1 commit intomainfrom
Open
Conversation
49cd268 to
4dc93c9
Compare
There was a problem hiding this comment.
Pull request overview
Adds Integration Services “Inbox” resume-trigger support to the resumable runtime by treating Inbox triggers as async-external (similar to API triggers) during the auto-resume polling phase, and exposes the related trigger type via runtime re-exports.
Changes:
- Skip
INBOXtriggers (along withAPI) when checking stored triggers for immediate auto-resume after suspension. - Add a regression test ensuring
read_triggeris not called for Inbox triggers during the auto-resume check. - Re-export
UiPathIntegrationTriggerand bump package version to0.10.2.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/uipath/runtime/resumable/runtime.py |
Updates auto-resume fired-trigger polling to exclude INBOX triggers and adjusts docstring. |
tests/test_resumable.py |
Adds coverage for “Inbox triggers must not be polled pre-resume”. |
src/uipath/runtime/resumable/trigger.py |
Re-exports UiPathIntegrationTrigger for backward compatibility. |
src/uipath/runtime/resumable/__init__.py |
Re-exports UiPathIntegrationTrigger from the resumable package. |
src/uipath/runtime/__init__.py |
Re-exports UiPathIntegrationTrigger from the top-level runtime package. |
pyproject.toml |
Bumps package version to 0.10.2. |
uv.lock |
Updates the editable package version entry to 0.10.2. |
Comments suppressed due to low confidence (1)
src/uipath/runtime/resumable/runtime.py:155
- The docstring says this returns a resume map for fired triggers or
None, but when triggers exist and all are skipped (e.g., only API/INBOX), the method can still end up returning an empty dict via_build_resume_map([]). Consider returningNonewhen there are no pollable triggers / when the built resume map is empty, or update the docstring to mention the empty-dict case.
Returns:
A resume map of {interrupt_id: resume_data} for fired triggers, or None.
"""
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+163
to
+164
| if t.trigger_type | ||
| not in (UiPathResumeTriggerType.API, UiPathResumeTriggerType.INBOX) |
0e16bbb to
721c429
Compare
721c429 to
da349db
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support for inbox triggers
Development Package