feat(entities): apply resource overrides on all byName paths - #714
Open
deepeshrai-tech wants to merge 2 commits into
Open
feat(entities): apply resource overrides on all byName paths#714deepeshrai-tech wants to merge 2 commits into
deepeshrai-tech wants to merge 2 commits into
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
Contributor
|
Two issues found this run — see inline comments for details. |
deepeshrai-tech
force-pushed
the
feat/refs-entities-overrides
branch
from
September 5, 2026 09:10
e045dce to
d276fd1
Compare
Contributor
|
One new finding this run — see inline comment for details. |
Data Fabric now honours the ambient resource-overrides table for every path that carries an entity name on the wire — matching the Assets ref-based PR (#684) and closing the parity gap identified in the framework review. Public byName reads (`getByName`, `getRecordsByName`, `getRecordByName`) and every operational method that accepts `{ name }` on an `EntityRef` (`insertRecord(s)`, `updateRecord(s)`, `deleteRecord(s)`, `queryRecords`, `importRecords`, `downloadAttachment`, `uploadAttachment`, `deleteAttachment`) now route the design-time name through `resolveOverride('Entity', name)` before the URL is built. A single `resolveEntityName` helper is invoked in `unwrapEntityRef` for the operational family and inline for the three public reads. DF does not accept a `folderPath` header, so the redirect's `folderPath` field is intentionally ignored — only the redirected `name` reaches the URL. The unscoped `entity.<name>` publisher key is what matches; scoped keys with a folder path never apply to DF and are quietly bypassed. `{ id }` refs are untouched — id-based routes have no name to override. Tests: - `getByName` — override redirects the URL entity name - `insertRecord({ name })` — override redirects the URL entity name; documented as the representative for the whole shared `unwrapEntityRef` code path. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
deepeshrai-tech
force-pushed
the
feat/refs-entities-overrides
branch
from
September 7, 2026 06:18
d276fd1 to
eb525cd
Compare
Contributor
|
One new finding this run — see inline comment for details. |
Contributor
|
✅ No issues found. Checked for bugs and CLAUDE.md compliance. |
|
Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
deepeshrai-tech
force-pushed
the
feat/refs-entities-overrides
branch
from
September 8, 2026 16:51
31f01a1 to
4936227
Compare
Contributor
|
✅ No issues found. Checked for bugs and CLAUDE.md compliance. |
AditiGoyalUipath
approved these changes
Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Data Fabric now honours the ambient resource-overrides table for every path that carries an entity name on the wire — matching the Assets ref-based PR (#684) and closing the parity gap identified in the framework review.
Public byName reads — now applied:
getByName,getRecordsByName,getRecordByName.Operational methods that accept
{ name }on anEntityRef— one shared code path viaunwrapEntityRefnow applies overrides for the whole family:insertRecord(s),updateRecord(s),deleteRecord(s),queryRecords,importRecords,downloadAttachment,uploadAttachment,deleteAttachment.A single
resolveEntityNamehelper is invoked inunwrapEntityReffor the operational family and inline for the three public reads.Folder scoping caveat. DF does not accept a
folderPathheader, so the redirect'sfolderPathfield is intentionally ignored — only the redirectednamereaches the URL. The unscopedentity.<name>publisher key is what matches; scoped keys with a folder path never apply to DF and are quietly bypassed.{ id }refs are untouched — id-based routes have no name to override.Test plan
npm run typecheck— cleannpm run lint— 0/0npm run test:unit— 2731/2731 pass (single failing file is a pre-existingcheck-samples.test.tsmodule-not-found)npm run build— exit 0getByName— override redirects the URL entity nameinsertRecord({ name })— override redirects the URL entity name; documented as the representative for the whole sharedunwrapEntityRefcode path🤖 Generated with Claude Code