Add Windows support, expanded controls, and Bridge hardening - #1
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ccefce7e93
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "installer/THIRD_PARTY_NOTICES.md" | ||
| "installer/THIRD_PARTY_NOTICES.md", | ||
| "installer/native-runtime/native-runtime.json", | ||
| "installer/native-runtime/node_modules/@koromix/koffi-win32-x64/win32_x64/koffi.node" |
There was a problem hiding this comment.
Include the packaged native runtime files
This newly required resource is not present in the committed plugin: the repository currently only has installer/native-runtime/native-runtime.json, while node_modules/.../koffi.node is absent because node_modules/ is ignored. As a result, npm run install:plugin fails before copying the plugin on every platform with Bundled Bridge resource is missing, so the repository installation path is broken unless these runtime files are shipped or generated before validation.
Useful? React with 👍 / 👎.
| ["@koromix/koffi-win32-x64/index.js", "node_modules/@koromix/koffi-win32-x64/index.js"], | ||
| ["@koromix/koffi-win32-x64/package.json", "node_modules/@koromix/koffi-win32-x64/package.json"], | ||
| ["@koromix/koffi-win32-x64/README.md", "node_modules/@koromix/koffi-win32-x64/README.md"], | ||
| ["@koromix/koffi-win32-x64/win32_x64/koffi.node", "node_modules/@koromix/koffi-win32-x64/win32_x64/koffi.node"] |
There was a problem hiding this comment.
Avoid copying win32-only optional deps on macOS builds
On macOS/Linux, npm install skips @koromix/koffi-win32-x64 because it is an optional dependency constrained to os: win32, but this build always deletes installer/native-runtime and then copies that package from node_modules. Supported macOS flows such as npm run setup and the new npm test therefore fail during build:plugin before Bridge installation; the build needs to fetch/package the Windows runtime in a platform-independent way or avoid regenerating it on non-Windows hosts.
Useful? React with 👍 / 👎.
Summary
Implementation notes
The commits are separated by review topic: Windows platform support, hidden helper processes, action latency, controls, task display, Bridge lifecycle hardening, process-bound focus, and independent build closure.
Windows discovery does not pin versioned WindowsApps paths. Native focus is isolated behind the platform adapter, targets the PID associated with the active CDP connection, and uses a bounded attached-input fallback. Renderer/CDP behavior remains version-sensitive and replaceable.
Validation
npm installnpm run checkverifypassed before handoffResidual validation
This PR was not exercised with a physical D200 device, Ulanzi Studio, or simultaneous Stable/Beta write actions during this handoff. Windows foreground policy can still reject
SetForegroundWindow; task navigation remains successful and activation failure is reported separately without unbounded retries.