Repository navigation
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Derive ONNX wire counts from byte bounds and reuse one validated description per operation. Batch wire checks without dropping descriptor or scalar validation. Retain Adam/SGD optimizer state through closed skops trust and loader catalogs, committing every attribute to the fitted-state digest.
Use CBM with closed wrappers and verified native prediction state. Reject categorical CTR storage until it has a bounded preflight.
Admit plain dtype state, NumPy scalar type parameters and closed sklearn score/NumPy elementwise function references with owning-loader checks. Keep all new values bound to the complete fitted-state commitment. Visit fitted categorical clones and avoid repeated composite parameters that exceed the existing depth limit. The unreleased format-1 pipeline parameter projection now uses constructor-list references; older pipeline bundles require re-export. No manifest schema or dependency changes.
* perf: reuse bounded canonical JSON validation * perf: prove structure equality from stored bytes
* perf: reuse verified tree adapter snapshots * fix: avoid expanded tree validation buffers
* feat: add composite native pipelines * fix(cli): group pipeline metadata before members
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First complete version of mlbundle: one pickle-free
.mlbundlefile with the model in its native format, a rich manifest, a locally inferred schema and the model's structure, plus the validating reader.What is included
docs/format.mdand linked sections): closed member list, strict manifest, canonical JSON, integrity records, limits, format version 1.inspect.mlbundle.export,mlbundle.load,mlbundle.inspect; CLImlbundle inspect/mlbundle verify.Pipelinewhose last step is an XGBoost or CatBoost estimator is stored asmodel.skops(transformers) plus the native member, each loaded and verified by its own adapter, then rebuilt as a realPipeline. Transformer output width is proven from fitted state without data.mlbundle[schema]extra computesschema.jsonlocally with mlschema; sample rows only with explicitsample_rows=.Added after the first review round
AdamOptimizer/SGDOptimizertrusted).FunctionTransformer).0.1.0a1; manualpublish.yml(Trusted Publishing,mainonly,pypi_envapproval) reusing CI, which now builds one wheel/sdist and tests that exact wheel on both OSes.Verification
uv run ruff check .,uv run ruff format --check .,uv run pyright: clean.uv run pytest: 1,476 passed, 91.88% coverage, on Ubuntu and Windows in CI.Points for review
Depthwise/Lossguidetrees are rejected; state extraction uses CatBoost's private_serialize_model()because there is no public in-memory save; the extra adds about 444 MB to an environment.memory,transform_inputand metadata routing are rejected;KNNImputerandFeatureUnionhave no width rule and are rejected in composites; all-scikit-learn pipelines still carry no structure.HistGradientBoosting*is rejected at export (needs an extra skops trusted type).AGENTS.md"A note from the maintainer" was drafted during bootstrap and needs the owner's own wording.The owner decided to reserve the PyPI name by publishing this pre-alpha as
0.1.0a1after this merge; seedocs/publishing.md. The independent security review is still pending and the README says so.Not included: GitHub releases, version tags, bundle signing, sklearn-to-ONNX conversion, MLSuite integration.