Repository navigation
Conversation
BREAKING CHANGE: Re-export bundles without schema or with schema v1. Use target_names in export and target.names in the manifest. Format 1 remains unfrozen; package version becomes 0.1.0a2.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promotes
developtomainfor the0.1.0a2pre-alpha.What changes since 0.1.0a1
schema.jsonis always written and always required. Withtraining_data=it is inferred from the frame ("source": "training_data"); without it, mlschema infers a default from one row ("source": "default").mappedTois the feature name when the model exposes names, and the 0-based position otherwise. Generated names start atfeature_0.export(..., onehot_separator="__"); the separator is stored inschema.json.export(..., target_names=[...])replacestarget_name; the manifest recordstarget.names.schemaextra.inspectandloaddo not.--pre.Compatibility
Bundles written by 0.1.0a1 are rejected and must be re-exported. Format 1 is not frozen.
Verification
developfor feat: require schema v2 and output-major targets #18: lint, types, build, wheel tests on Ubuntu and Windows.twine check --strictpasses for both artifacts.