fix(extension): replace configuration proxy to prevent activation failure - #11
Open
shuntianyifang wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修改内容
修复 DeepSec 扩展在新版 VS Code 中无法激活的问题。
本次修改:
WorkspaceConfiguration对象的 Proxy 包装;deepsec.*配置优先级;vibeguard.*配置回退;deepsec.*;问题原因
原来的
configuration()使用 Proxy 替换WorkspaceConfiguration.get和inspect。新版 VS Code 将这些属性暴露为不可配置的只读属性。Proxy 返回不同的
方法实现时会违反 JavaScript Proxy 不变量,导致扩展激活失败:
扩展在注册命令前退出,因此会出现命令面板中能看到命令,但执行时提示:
验证结果
修复 #10