Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
Expand Up @@ -767,7 +767,6 @@
/types/carbon__colors/ @vpicone @szbihary
/types/carbon__elements/ @metonym
/types/carbon__layout/ @vpicone
/types/carbon__motion/ @vpicone
/types/carbon__themes/ @vpicone
/types/carbon__type/ @vpicone
/types/carbone/ @apatryda
Expand Down
4 changes: 4 additions & 0 deletions notNeededPackages.json
Original file line number Diff line number Diff line change
Expand Up @@ -676,6 +676,10 @@
"libraryName": "@carbon/icons-react",
"asOfVersion": "11.29.0"
},
"carbon__motion": {
"libraryName": "@carbon/motion",
"asOfVersion": "11.44.0"
},
"carbon__pictograms-react": {
"libraryName": "@carbon/pictograms-react",
"asOfVersion": "11.89.0"
Expand Down
5 changes: 0 additions & 5 deletions types/carbon__motion/.npmignore

This file was deleted.

8 changes: 0 additions & 8 deletions types/carbon__motion/carbon__motion-tests.ts

This file was deleted.

20 changes: 0 additions & 20 deletions types/carbon__motion/index.d.ts

This file was deleted.

17 changes: 0 additions & 17 deletions types/carbon__motion/package.json

This file was deleted.

19 changes: 0 additions & 19 deletions types/carbon__motion/tsconfig.json

This file was deleted.

7 changes: 7 additions & 0 deletions types/express-session/express-session-tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,13 @@ app.use(
}),
);

app.use(
session({
secret: "keyboard cat",
cookie: (req) => ({ secure: req.secure }),
}),
);

// Various `crypto.CipherKey` types
app.use(session({ secret: Buffer.from("keyboard cat", "utf8") }));
app.use(session({ secret: crypto.createSecretKey(Buffer.from("keyboard cat", "utf8")) }));
Expand Down
4 changes: 2 additions & 2 deletions types/express-session/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,10 @@ declare namespace session {
store?: Store | undefined;

/**
* Settings object for the session ID cookie.
* Settings object for the session ID cookie, or a callback that dynamically generates it based on the incoming request.
* @see CookieOptions
*/
cookie?: CookieOptions | undefined;
cookie?: CookieOptions | ((req: express.Request) => CookieOptions) | undefined;

/**
* Force the session identifier cookie to be set on every response. The expiration is reset to the original `maxAge`, resetting the expiration countdown.
Expand Down
2 changes: 1 addition & 1 deletion types/express-session/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": true,
"name": "@types/express-session",
"version": "1.18.9999",
"version": "1.19.9999",
"projects": [
"https://github.com/expressjs/session"
],
Expand Down
1 change: 1 addition & 0 deletions types/mssql/index.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ export interface config {
pool?: PoolOpts<Connection> | undefined;
arrayRowMode?: boolean | undefined;
authentication?: tds.ConnectionAuthentication | undefined;
validateConnection?: "socket" | boolean | undefined;
/**
* Invoked before opening the connection. The parameter conn is the configured
* tedious Connection. It can be used for attaching event handlers.
Expand Down
2 changes: 1 addition & 1 deletion types/mssql/package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"private": true,
"name": "@types/mssql",
"version": "9.1.9999",
"version": "12.3.9999",
"projects": [
"https://www.npmjs.com/package/mssql"
],
Expand Down
4 changes: 3 additions & 1 deletion types/pdfkit/index.d.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
/// <reference types="node" />

type PDFKitReadable = import("stream").Readable;

declare namespace PDFKit {
interface PDFGradient {
new(document: any): PDFGradient;
Expand Down Expand Up @@ -862,7 +864,7 @@ declare namespace PDFKit {

interface PDFDocument
extends
NodeJS.ReadableStream,
PDFKitReadable,
Mixins.PDFMetadata,
Mixins.PDFAnnotation,
Mixins.PDFColor,
Expand Down
10 changes: 10 additions & 0 deletions types/pdfkit/pdfkit-tests.ts
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import mtext = require("pdfkit/js/mixins/text");

import PDFDocument = require("pdfkit");
import PDFDocumentStandalone = require("pdfkit/js/pdfkit.standalone");
import stream = require("stream");

import font = require("pdfkit/js/mixins/fonts");
import pdfData = require("pdfkit/js/data");
Expand All @@ -34,6 +35,15 @@ var doc: PDFKit.PDFDocument = new PDFDocument({
fontLayoutCache: true,
});

const readable: stream.Readable = doc;

// $ExpectType PDFDocument
doc.destroy();
// $ExpectType boolean
doc.destroyed;
// $ExpectType boolean
doc.readableEnded;

// $ExpectType PDFDocument
doc.addPage();
// $ExpectType PDFDocument
Expand Down
11 changes: 11 additions & 0 deletions types/three/examples/jsm/Addons.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ export * from "./effects/OutlineEffect.js";
export * from "./effects/ParallaxBarrierEffect.js";
export * from "./effects/StereoEffect.js";

export * from "./environments/ColorEnvironment.js";
export * from "./environments/DebugEnvironment.js";
export * from "./environments/RoomEnvironment.js";

Expand All @@ -51,9 +52,11 @@ export * from "./geometries/RoundedBoxGeometry.js";
export * from "./geometries/TeapotGeometry.js";
export * from "./geometries/TextGeometry.js";

export * from "./helpers/AnimationPathHelper.js";
export * from "./helpers/LightProbeHelper.js";
export * from "./helpers/OctreeHelper.js";
export * from "./helpers/PositionalAudioHelper.js";
export * from "./helpers/RapierHelper.js";
export * from "./helpers/RectAreaLightHelper.js";
export * from "./helpers/TextureHelper.js";
export * from "./helpers/VertexNormalsHelper.js";
Expand Down Expand Up @@ -98,6 +101,7 @@ export * from "./loaders/LDrawLoader.js";
export * from "./loaders/LottieLoader.js";
export * from "./loaders/LUT3dlLoader.js";
export * from "./loaders/LUTCubeLoader.js";
export * from "./loaders/LUTImageLoader.js";
export * from "./loaders/LWOLoader.js";
export * from "./loaders/MD2Loader.js";
export * from "./loaders/MDDLoader.js";
Expand Down Expand Up @@ -126,6 +130,7 @@ export * from "./materials/LDrawConditionalLineMaterial.js";

export * from "./math/Capsule.js";
export * from "./math/ColorConverter.js";
export * as ColorSpaces from "./math/ColorSpaces.js";
export * from "./math/ConvexHull.js";
export * from "./math/ImprovedNoise.js";
export * from "./math/Lut.js";
Expand Down Expand Up @@ -165,6 +170,7 @@ export { Water as Water2 } from "./objects/Water2.js";
export type { WaterOptions as Water2Options } from "./objects/Water2.js";

export * from "./physics/AmmoPhysics.js";
export * from "./physics/JoltPhysics.js";
export * from "./physics/RapierPhysics.js";

export * from "./postprocessing/AfterimagePass.js";
Expand All @@ -175,6 +181,7 @@ export * from "./postprocessing/CubeTexturePass.js";
export * from "./postprocessing/DotScreenPass.js";
export * from "./postprocessing/EffectComposer.js";
export * from "./postprocessing/FilmPass.js";
export * from "./postprocessing/FXAAPass.js";
export * from "./postprocessing/GlitchPass.js";
export * from "./postprocessing/GTAOPass.js";
export * from "./postprocessing/HalftonePass.js";
Expand All @@ -185,6 +192,7 @@ export * from "./postprocessing/OutputPass.js";
export * from "./postprocessing/Pass.js";
export * from "./postprocessing/RenderPass.js";
export * from "./postprocessing/RenderPixelatedPass.js";
export * from "./postprocessing/RenderTransitionPass.js";
export * from "./postprocessing/SAOPass.js";
export * from "./postprocessing/SavePass.js";
export * from "./postprocessing/ShaderPass.js";
Expand Down Expand Up @@ -234,6 +242,7 @@ export * from "./shaders/LuminosityShader.js";
export * from "./shaders/MirrorShader.js";
export * from "./shaders/NormalMapShader.js";
export * from "./shaders/OutputShader.js";
export * from "./shaders/PoissonDenoiseShader.js";
export * from "./shaders/RGBShiftShader.js";
export * from "./shaders/SAOShader.js";
export * from "./shaders/SepiaShader.js";
Expand All @@ -257,9 +266,11 @@ export * from "./textures/FlakesTexture.js";

export * as BufferGeometryUtils from "./utils/BufferGeometryUtils.js";
export * as CameraUtils from "./utils/CameraUtils.js";
export * as ColorUtils from "./utils/ColorUtils.js";
export * as GeometryCompressionUtils from "./utils/GeometryCompressionUtils.js";
export * as GeometryUtils from "./utils/GeometryUtils.js";
export * from "./utils/LDrawUtils.js";
export * from "./utils/SceneOptimizer.js";
export * as SceneUtils from "./utils/SceneUtils.js";
export * from "./utils/ShadowMapViewer.js";
export * as SkeletonUtils from "./utils/SkeletonUtils.js";
Expand Down
15 changes: 5 additions & 10 deletions types/three/examples/jsm/controls/FirstPersonControls.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,11 +24,6 @@ declare class FirstPersonControls extends Controls<{}> {
*/
autoForward: boolean;

/**
* Whether or not it's possible to look around. Default is `true`.
*/
activeLook: boolean;

/**
* Whether or not the camera's height influences the forward movement speed. Default is `false`.
* Use the properties {@link .heightCoef}, {@link .heightMin} and {@link .heightMax} for configuration
Expand Down Expand Up @@ -78,11 +73,6 @@ declare class FirstPersonControls extends Controls<{}> {
*/
constructor(object: Camera, domElement?: HTMLElement | SVGElement);

/**
* Should be called if the application window is resized.
*/
handleResize(): void;

/**
* Ensures the controls orient the camera towards the defined target position.
* @param vector A vector representing the target position.
Expand All @@ -96,6 +86,11 @@ declare class FirstPersonControls extends Controls<{}> {
* @param z The z component of the world space position.
*/
lookAt(x: number, y: number, z: number): this;

/**
* @deprecated The controls now handle resize internally.
*/
handleResize(): void;
}

export { FirstPersonControls };
24 changes: 24 additions & 0 deletions types/three/examples/jsm/controls/TransformControls.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,9 @@ export interface TransformControlsEventMap {
"showX-changed": { value: unknown };
"showY-changed": { value: unknown };
"showZ-changed": { value: unknown };
"showXY-changed": { value: unknown };
"showYZ-changed": { value: unknown };
"showXZ-changed": { value: unknown };
"minX-changed": { value: unknown };
"maxX-changed": { value: unknown };
"minY-changed": { value: unknown };
Expand Down Expand Up @@ -128,6 +131,27 @@ declare class TransformControls extends Controls<TransformControlsEventMap> {
*/
showZ: boolean;

/**
* Whether the xy-plane helper should be visible or not.
*
* @default true
*/
showXY: boolean;

/**
* Whether the xy-plane helper should be visible or not.
*
* @default true
*/
showYZ: boolean;

/**
* Whether the xy-plane helper should be visible or not.
*
* @default true
*/
showXZ: boolean;

/**
* The minimum allowed X position during translation. Default is `-Infinity`.
*/
Expand Down
Loading