restoring compilation in Rocq 9.4alpha - #256
Merged
Merged
Conversation
…in sync with UniMath PR2083 but there is a type-checking error in Initiality/SyntacticCategory.v as well, which is not dealt with in the present commit
nmvdw
approved these changes
Sep 3, 2026
Contributor
|
Thanks for the fix! The solution in |
Member
Author
|
Thank you @nmvdw for having looked through it. Ideally, the author of this formalization (@peterlefanulumsdaine) could try to figure out what went wrong before this fix, maybe a coercion that is no longer applied by the system. However, there is currently strictly no need to make an effort towards reestablishing the previous elegant proof scripts. Only one place in my fix is ugly. It can easily wait until 9.4alpha has become an official release and then the working environment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the essential problem is that "is" is now a keyword, the solution in sync with UniMath PR2083
but there is a type-checking error in Initiality/SyntacticCategory.v as well, which is not dealt with in the first commit, however, it is solved in 2720547 , but the solution is partly ugly.