CHANGE: Update asset InputSystem.inputsettings to use UI Toolkit framework#2393
Open
josepmariapujol-unity wants to merge 15 commits intodevelopfrom
Open
CHANGE: Update asset InputSystem.inputsettings to use UI Toolkit framework#2393josepmariapujol-unity wants to merge 15 commits intodevelopfrom
josepmariapujol-unity wants to merge 15 commits intodevelopfrom
Conversation
josepmariapujol-unity
changed the title
Explicitly update the SerializedObject in InputActionImporterEditor.
![u-pr[bot]](https://avatars.githubusercontent.com/in/1201017?s=60&v=4){kind=small}
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## develop #2393 +/- ##
===========================================
- Coverage 78.13% 78.10% -0.03%
===========================================
Files 483 483
Lines 98770 98793 +23
===========================================
- Hits 77169 77165 -4
- Misses 21601 21628 +27 Flags with carried forward coverage won't be shown. Click here to find out more.
|
Collaborator
|
/test_plan |
Contributor
Test Plan
Summary of Changes & Risk AssessmentSummary of ChangesThis PR migrates the inspector UI for Risk Assessment
Test ScenariosFunctional Testing
Regression Testing
Edge Cases
💡 This test plan updates automatically when 🤖 Helpful? Please react with 👍/👎 | Questions❓Please reach out in Slack #ask-u-pr |
Collaborator
|
Text can go outside the button when scaled |
Pauliusd01
requested changes
Mar 30, 2026
Collaborator
Pauliusd01
left a comment
Pauliusd01
left a comment
There was a problem hiding this comment.
Text/button isn't updated correctly when multiple inspectors are used
https://github.com/user-attachments/assets/a9e54976-0525-4cd6-9094-c3b6c8fcc030
Contributor
There was a problem hiding this comment.
This PR migrates the InputSettings inspector to UI Toolkit. While the refactoring is mostly solid, there are several important issues that should be addressed:
- Compatibility: The use of the
HelpBoxVisualElement may break compatibility with Unity versions older than 2021.1. - UI State/Sync: The new UI Toolkit implementation introduces a regression where the UI can become stale if settings are changed externally (e.g., via Project Settings or Undo), unlike the previous IMGUI implementation which polled every frame.
- Polishing: Several minor issues regarding string formatting (double spaces), unused parameters, and inconsistent spelling were identified.
Please see the inline comments for specific details and suggested improvements.
🤖 Helpful? 👍/👎
Collaborator
Author
|
Will review review the PR again after the AI suggestions |
Pauliusd01
approved these changes
Apr 22, 2026
K-Tone
requested changes
Apr 24, 2026
Collaborator
K-Tone
left a comment
K-Tone
left a comment
There was a problem hiding this comment.
Looks good to me, but can we get an answer to the UPR comment?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR is updating the UI for asset
InputSystem.inputsettingsto use UI Toolkit framework.Before:
After:
Testing status & QA
Once you create an input settings check the asset and click the button, see video.
Screen.Recording.2026-03-23.at.12.58.07.mov
Page refresh test:
assigne.mov
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.