FIX: Render parameter-less processors as a plain header and the top button row no longer clips when the properties panel is scrolled [UUM-144325] by Pauliusd01 · Pull Request #2462 · Unity-Technologies/InputSystem

Pauliusd01 · 2026-08-04T11:28:25Z

Description

Note

This pull request was generated automatically. Please review carefully before merging.

Two related fixes in the Input Actions editor's Action Properties view.

Parameter-less processors/interactions [UUM-144325]. The NameAndParametersListViewItem constructor always populated the list item's Foldout regardless of whether the processor or interaction had any editable parameters, so a parameter-less entry such as "Invert" showed an expandable foldout whose arrow animated on click but revealed no content. The foldout content is now gated on parameterListView.hasUIToShow; entries with no parameters render as a plain, non-collapsible header — the expand arrow is hidden with visibility (so the label stays aligned with the foldout items) and the header toggle's picking is disabled, while the move/delete buttons stay clickable. This mirrors the IMGUI editor's existing hasUIToShow branch.

Toolbar clipped when the properties panel scrolls. The top toolbar row (#control-schemes-toolbar-container) was vertically shrinkable, so when the Action Properties content grew tall enough to overflow, the flex column compressed the toolbar and clipped its buttons once a scrollbar appeared. It now has flex-shrink: 0, keeping its height while the body absorbs the overflow.

Testing status & QA

No automated test added — both changes are UI Toolkit layout/visual behaviour in the Action Properties view, which has no test harness that reaches it and depends on in-editor rendering.
QA: for the foldout, re-run the repro in UUM-144325 and confirm a parameter-less processor/interaction renders as a plain header (no expand arrow, no empty expandable area) with working move/delete buttons. Separately, expand Processors on an action until the Action Properties panel shows a scrollbar and confirm the top toolbar buttons are no longer clipped.

Overall Product Risks

Complexity: low
Halo Effect: low (both changes are confined to the Input Actions editor's Action Properties view; no public API surface touched)
Risk rating: 3/5 — Rating is 3 because this UITK item view has zero automated test coverage, and the arrow-hiding/pickingMode approach relies on Foldout internal USS class names and picking behaviour that need in-editor verification.

Comments to reviewers

N/A

Checklist

Before review:

Changelog entry added.
- Explains the change in Changed, Fixed, Added sections.
- For API change contains an example snippet and/or migration example.
- JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
- Jira port for the next release set as "Resolved".
Tests added/changed, if applicable.
- Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
- Performance tests.
- Integration tests.
Docs for new/changed API's.
- Xmldoc cross references are set correctly.
- Added explanation how the API works.
- Usage code examples added.
- The manual is updated, if needed.

During merge:

Commit message for squash-merge is prefixed with one of the list:
- NEW: ___.
- FIX: ___.
- DOCS: ___.
- CHANGE: ___.
- RELEASE: 1.1.0-preview.3.

…nstead of an empty foldout in the Input Actions editor [UUM-144325] In the UITK Input Actions editor's Action Properties view, every processor/interaction list item was rendered with an expandable foldout regardless of whether it had any editable parameters, so a parameter-less processor such as "Invert" showed a foldout whose arrow animated on click but revealed no content. The NameAndParametersListViewItem(VisualElement root, ParameterListView parameterListView, ButtonProperties buttonProperties) constructor now gates the foldout content on parameterListView.hasUIToShow. When there are no editable parameters it hides the header toggle's expand arrow (unity-toggle__checkmark) and sets the toggle's pickingMode to Ignore, so the item reads as a plain, non-collapsible header while the move-up/move-down/delete buttons stay clickable. This mirrors the IMGUI editor, which uses the same hasUIToShow predicate to choose foldout-vs-label. Jira: https://jira.unity3d.com/browse/UUM-144325

…144325] Hide the parameter-less header's expand arrow with visibility:Hidden instead of display:None so the arrow retains its layout box and the label stays in the same column as the labels of items that do have a foldout.

Pauliusd01 · 2026-08-04T11:43:16Z

After the change with no foldout invert and others will look like this:

… panel scrolls Pin the top toolbar row (flex-shrink: 0) so the flex column steals overflow height from the body instead of compressing the toolbar and clipping its buttons once the Action Properties panel is tall enough to show a scrollbar.

Pauliusd01 · 2026-08-04T11:48:45Z

Also, a small change for an undocumented top row bug that I noticed while testing:

u-pr

💡 Harness Review

The change is small and localized, and I did not find a concrete behavioral regression in either the parameterless-item handling or the toolbar layout adjustment.

_{Reviewed commit 5b9d58c}

_{🤖 Helpful? 👍/👎}

codecov-github-com · 2026-08-04T12:16:21Z

Codecov Report

Attention: Patch coverage is 45.45455% with 6 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
...UITKAssetEditor/Views/NameAndParametersListView.cs	45.45%	6 Missing ⚠️

@@           Coverage Diff            @@
##           develop    #2462   +/-   ##
========================================
  Coverage    78.95%   78.96%           
========================================
  Files          767      767           
  Lines       140780   140802   +22     
========================================
+ Hits        111153   111179   +26     
+ Misses       29627    29623    -4

Flag	Coverage Δ
inputsystem_MacOS_6000.0	`5.31% <0.00%> (-0.01%)`	⬇️
inputsystem_MacOS_6000.0_project	`77.49% <45.45%> (-0.01%)`	⬇️
inputsystem_MacOS_6000.3	`5.31% <0.00%> (-0.01%)`	⬇️
inputsystem_MacOS_6000.3_project	`77.49% <45.45%> (-0.01%)`	⬇️
inputsystem_MacOS_6000.5	`5.30% <0.00%> (-0.01%)`	⬇️
inputsystem_MacOS_6000.5_project	`77.55% <45.45%> (-0.01%)`	⬇️
inputsystem_MacOS_6000.6	`5.30% <0.00%> (-0.01%)`	⬇️
inputsystem_MacOS_6000.6_project	`77.55% <45.45%> (-0.01%)`	⬇️
inputsystem_MacOS_6000.7	`5.30% <0.00%> (-0.01%)`	⬇️
inputsystem_MacOS_6000.7_project	`77.55% <45.45%> (-0.01%)`	⬇️
inputsystem_Ubuntu_6000.0	`5.31% <0.00%> (-0.01%)`	⬇️
inputsystem_Ubuntu_6000.0_project	`77.40% <45.45%> (-0.01%)`	⬇️
inputsystem_Ubuntu_6000.3	`5.31% <0.00%> (-0.01%)`	⬇️
inputsystem_Ubuntu_6000.3_project	`77.40% <45.45%> (-0.01%)`	⬇️
inputsystem_Ubuntu_6000.5	`5.30% <0.00%> (-0.01%)`	⬇️
inputsystem_Ubuntu_6000.5_project	`77.46% <45.45%> (-0.01%)`	⬇️
inputsystem_Ubuntu_6000.6	`5.30% <0.00%> (-0.01%)`	⬇️
inputsystem_Ubuntu_6000.6_project	`77.46% <45.45%> (-0.01%)`	⬇️
inputsystem_Ubuntu_6000.7	`5.30% <0.00%> (-0.01%)`	⬇️
inputsystem_Ubuntu_6000.7_project	`77.47% <45.45%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...UITKAssetEditor/Views/NameAndParametersListView.cs	`63.47% <45.45%> (-2.56%)`	⬇️

... and 2 files with indirect coverage changes

ℹ️ Need help interpreting these results?

K-Tone

Code-wise looks good, just asking to rephrase the release note so that it appears less robotic and easier to digest. I would also keep an eye on those long comments in code that really don't explain much complexity at all in these cases and just steal attention.

Co-authored-by: Anthony Yakovlev <anthony.yakovlev@gmail.com>

…M-144325]

Pauliusd01 · 2026-08-05T04:36:12Z

Code-wise looks good, just asking to rephrase the release note so that it appears less robotic and easier to digest. I would also keep an eye on those long comments in code that really don't explain much complexity at all in these cases and just steal attention.

Thanks, It does tend to yap in the comments, I tried to unsloppify it.

K-Tone

thanks!

Pauliusd01 self-assigned this Aug 4, 2026

Pauliusd01 requested a review from josepmariapujol-unity August 4, 2026 11:49

Pauliusd01 marked this pull request as ready for review August 4, 2026 11:51

Pauliusd01 requested review from K-Tone and removed request for josepmariapujol-unity August 4, 2026 11:52

u-pr Bot reviewed Aug 4, 2026

View reviewed changes

K-Tone reviewed Aug 4, 2026

View reviewed changes

Comment thread Packages/com.unity.inputsystem/CHANGELOG.md Outdated

K-Tone requested changes Aug 4, 2026

View reviewed changes

Pauliusd01 and others added 2 commits August 5, 2026 07:27

Update Packages/com.unity.inputsystem/CHANGELOG.md

c8973ec

Co-authored-by: Anthony Yakovlev <anthony.yakovlev@gmail.com>

FIX: Remove redundant comments from parameter-less foldout change [UU…

dc30092

…M-144325]

Pauliusd01 requested a review from K-Tone August 5, 2026 04:36

K-Tone approved these changes Aug 5, 2026

View reviewed changes

Pauliusd01 merged commit 38c4df5 into develop Aug 5, 2026
61 of 112 checks passed

Pauliusd01 deleted the fix/uum-144325-parameterless-foldout branch August 5, 2026 09:03

Navigation Menu

Uh oh!

FIX: Render parameter-less processors as a plain header and the top button row no longer clips when the properties panel is scrolled [UUM-144325] - #2462

FIX: Render parameter-less processors as a plain header and the top button row no longer clips when the properties panel is scrolled [UUM-144325]#2462
Pauliusd01 merged 5 commits into
developfrom
fix/uum-144325-parameterless-foldout

Pauliusd01 commented Aug 4, 2026 •

edited

Loading

Uh oh!

Pauliusd01 commented Aug 4, 2026

Uh oh!

Pauliusd01 commented Aug 4, 2026 •

edited

Loading

Uh oh!

u-pr Bot left a comment

Uh oh!

codecov-github-com Bot commented Aug 4, 2026 •

edited

Loading

Uh oh!

Uh oh!

K-Tone left a comment

Uh oh!

Pauliusd01 commented Aug 5, 2026

Uh oh!

K-Tone left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Pauliusd01 commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Testing status & QA

Overall Product Risks

Comments to reviewers

Checklist

Uh oh!

Pauliusd01 commented Aug 4, 2026

Uh oh!

Pauliusd01 commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

u-pr Bot left a comment

Choose a reason for hiding this comment

💡 Harness Review

Uh oh!

codecov-github-com Bot commented Aug 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

K-Tone left a comment

Choose a reason for hiding this comment

Uh oh!

Pauliusd01 commented Aug 5, 2026

Uh oh!

K-Tone left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Pauliusd01 commented Aug 4, 2026 •

edited

Loading

Pauliusd01 commented Aug 4, 2026 •

edited

Loading

codecov-github-com Bot commented Aug 4, 2026 •

edited

Loading