FIX: CI Sample Test project failure & MacOS failures - #2466
Open
ritamerkl wants to merge 4 commits into
Open
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## develop #2466 +/- ##
===========================================
- Coverage 78.95% 78.95% -0.01%
===========================================
Files 767 767
Lines 140780 140807 +27
===========================================
+ Hits 111153 111172 +19
- Misses 29627 29635 +8 |
DOTNET_ROLL_FORWARD=LatestMajor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The test-samples.yml hasn't been touched since 2022 and the macos-12 image has since lost its .NET installation (or the package-validation-suite started requiring it). The macos-13 image is what the mobile CI jobs use and is actively maintained.
This fixes the Sample Test project CI failure.
Testing status & QA
None
Overall Product Risks
Comments to reviewers
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.