Skip to content

trunk shadow changes: com.unity.mobile.android-logcat #215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
pets-svc wants to merge 1 commit into
base: master
Choose a base branch
from
Open

trunk shadow changes: com.unity.mobile.android-logcat #215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions com.unity.mobile.android-logcat/Tests/Editor/AndroidLogcatNetTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ public void ValidateAssemblyReferences()
"System",
"System.Xml.Linq",
"UnityEngine.IMGUIModule",
"UnityEngine.UICommonModule",

@u-pr u-pr Bot Aug 23, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1

expectedReferences is an exact list: the loop below requires every entry to occur once. These new compiler-generated dependencies are unconditionally required even though the package is validated on 2021.3 and 2022.3 as well as current 6000/trunk Editors. In the older editor builds where these references are not emitted (the previous list did not contain either), this makes ValidateAssemblyReferences fail with a zero reference count, blocking the existing compatibility CI. Add the dependencies only for the Editor versions that emit them (using the relevant Unity version defines), rather than adding them to the common list.

🤖 Helpful? 👍/👎

"UnityEngine.CoreModule",
"UnityEngine.VideoModule",
"UnityEngine.TextRenderingModule",
Expand All @@ -48,6 +49,7 @@ public void ValidateAssemblyReferences()
"UnityEngine.ImageConversionModule",
"UnityEngine.JSONSerializeModule",
"UnityEditor.CoreModule",
"Unity.Scripting",
});

var referencedCount = expectedReferences.ToDictionary(s => s, s => 0);
Expand Down