[CI] Fix check_error_codes workflow - #568
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #568 +/- ##
==========================================
+ Coverage 79.96% 81.12% +1.15%
==========================================
Files 119 119
Lines 7179 7178 -1
Branches 3220 3220
==========================================
+ Hits 5741 5823 +82
+ Misses 1047 965 -82
+ Partials 391 390 -1 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. |
Before, the PR body wasn't indented correctly. Also add a trigger for this workflow on PRs that modify this workflow file.
bfbb96c to
5eefaa4
Compare
There was a problem hiding this comment.
🟡 Changes recommended
PR-controlled code still runs with a write-capable token.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates the error-code workflow to validate workflow changes on PRs and correctly format generated PR descriptions.
Changes:
- Adds a path-filtered
pull_requesttrigger. - Guards automatic label and PR creation steps during PR runs.
- Uses a multiline environment variable for the generated PR body.
File summaries
| File | Description |
|---|---|
.github/workflows/check_error_codes.yml |
Updates triggers, automation guards, PR-body formatting, and mismatch-step naming. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| pull_request: | ||
| paths: | ||
| - '.github/workflows/check_error_codes.yml' |
There was a problem hiding this comment.
GitHub always gives GITHUB_TOKEN read-only on pull_request from forks, no matter what the workflow declares. So the write permissions don’t apply there.
|
Tick the box to add this pull request to the merge queue (same as
|
Before, the PR body wasn't indented correctly.
Also add a trigger for this workflow on PRs that modify this workflow file.
Note
Low Risk
GitHub Actions workflow-only changes; no runtime or application code affected.
Overview
CI workflow fixes for
check_error_codes: the workflow now runs on pull requests that touch.github/workflows/check_error_codes.yml, so changes to the workflow are validated in PRs.Auto-remediation is disabled on PR runs. Steps that create the
error-codes-outdatedlabel and open an auto-update PR only run whengithub.event_name != 'pull_request'(scheduled/dispatch). PR runs still perform the version check and fail on mismatch via the dedicated Fail if version mismatch step.PR body formatting is fixed by moving the auto-PR description into a
PR_BODYenvironment variable (with GitHub Actions expressions for versions) and passing--body "$PR_BODY"togh pr create, instead of a long inline--bodystring with broken indentation/escaping.Reviewed by Cursor Bugbot for commit 5eefaa4. Bugbot is set up for automated code reviews on this repo. Configure here.