Skip to content

3D manifest smoke test#1776

Open
LanieOkorodudu wants to merge 1 commit into
UniversalViewer:devfrom
LanieOkorodudu:3D-test
Open

3D manifest smoke test#1776
LanieOkorodudu wants to merge 1 commit into
UniversalViewer:devfrom
LanieOkorodudu:3D-test

Conversation

@LanieOkorodudu

Copy link
Copy Markdown
Collaborator

Added smoke test for 3D manifest to verify that the 3D manifest is loaded and the viewer supports basis zoom and rotation interactions. The test don't currently verify model orientation changes because those values aren't available through the test environment.

@vercel

vercel Bot commented Jun 11, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
universalviewer Ready Ready Preview, Comment Jun 11, 2026 1:49pm

Request Review

@vercel

vercel Bot commented Jun 11, 2026

Copy link
Copy Markdown

@LanieOkorodudu is attempting to deploy a commit to the Universal Viewer Team on Vercel.

A member of the Team first needs to authorize it.

@demiankatz demiankatz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @LanieOkorodudu, I took a quick look at this -- see below for initial thoughts:

Comment thread __tests__/test.js
await page.mouse.wheel({ deltaY: -600 });
await page.mouse.wheel({ deltaY: 600 });

const uv = await page.$(".uv");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps I'm missing or misunderstanding something, but I don't quite see how this check is confirming the effect of the mouse wheel actions above. Same issue in the following test. From trying this manually, I see that there doesn't really seem to be anything we can measure to verify the effect of these actions.

I wonder if the basic test should check for a rendered canvas, just to further confirm that the right code has loaded.

For these other tests, I think they would be very valuable if we could confirm that they did anything... but if we can't, they may be misleading rather than helpful. Do we need to add something to the code itself to allow measurement? (That may be out of scope for the current work -- and if so, maybe we should just go with the most minimal test, and then open an issue to track the need for follow-up).

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@demiankatz, You're right, I tried using cameraOrbit but wasn't successful. I agree the zoom/rotation tests are a bit misleading right now since they only confirm that the interactions can be triggered, not that they actually changed anything. I'll simplify this to a basic smoke test that verifies the 3D manifest loads successfully and add your suggested check for a rendered canvas.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants