3D manifest smoke test#1776
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
@LanieOkorodudu is attempting to deploy a commit to the Universal Viewer Team on Vercel. A member of the Team first needs to authorize it. |
demiankatz
left a comment
There was a problem hiding this comment.
Thanks, @LanieOkorodudu, I took a quick look at this -- see below for initial thoughts:
| await page.mouse.wheel({ deltaY: -600 }); | ||
| await page.mouse.wheel({ deltaY: 600 }); | ||
|
|
||
| const uv = await page.$(".uv"); |
There was a problem hiding this comment.
Perhaps I'm missing or misunderstanding something, but I don't quite see how this check is confirming the effect of the mouse wheel actions above. Same issue in the following test. From trying this manually, I see that there doesn't really seem to be anything we can measure to verify the effect of these actions.
I wonder if the basic test should check for a rendered canvas, just to further confirm that the right code has loaded.
For these other tests, I think they would be very valuable if we could confirm that they did anything... but if we can't, they may be misleading rather than helpful. Do we need to add something to the code itself to allow measurement? (That may be out of scope for the current work -- and if so, maybe we should just go with the most minimal test, and then open an issue to track the need for follow-up).
There was a problem hiding this comment.
@demiankatz, You're right, I tried using cameraOrbit but wasn't successful. I agree the zoom/rotation tests are a bit misleading right now since they only confirm that the interactions can be triggered, not that they actually changed anything. I'll simplify this to a basic smoke test that verifies the 3D manifest loads successfully and add your suggested check for a rendered canvas.
Added smoke test for 3D manifest to verify that the 3D manifest is loaded and the viewer supports basis zoom and rotation interactions. The test don't currently verify model orientation changes because those values aren't available through the test environment.