Conversation
feiiiiii5
force-pushed
the
fix/tsv-infer-table-structure
branch
from
October 1, 2026 04:41
3a9ada9 to
a27bf88
Compare
Contributor
Author
|
Merged current With frozen dependencies, TSV has 28 passing tests and adjacent CSV has 70. The new flag regressions still fail on current |
partition_tsv() had no infer_table_structure parameter, so the kwarg landed in **kwargs and was dropped: Table.metadata.text_as_html was always set, even for partition(..., infer_table_structure=False) or a skip_infer_table_types list containing tsv. csv, xlsx, docx and odt all gate text_as_html on that flag; tsv did not. Adds the parameter with the same docstring as the other partitioners and gates the html on it, plus the two regression tests the csv and xlsx partitioner tests already have.
feiiiiii5
force-pushed
the
fix/tsv-infer-table-structure
branch
from
October 5, 2026 04:29
bf6728d to
622458a
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
partition_tsv()silently ignoresinfer_table_structure=False, so callers still receiveTable.metadata.text_as_html. The flag is passed through bypartition()but absorbed by**kwargsin the TSV partitioner.Add the explicit parameter with the same default (
True) as the other table partitioners, and set HTML metadata only when enabled. Tests cover both flag values throughpartition_tsv()andpartition(). Plain table text and the default HTML output are preserved.The branch includes current
main(2c0c7a6c), retaining its TSV resource-limit tests and implementation. The required changelog/version bump is now 0.27.18.Test
uv.lock.main: 2 failed, 2 passed; against this branch: 4 passed.git diff --checkpasses.Full partitioner/extras suites and cross-platform tests were not run for this update. The broader 786-pass run in the earlier comment is historical.
Type of change: bug fix; no new dependency. Related #4373 changes numeric HTML generation, and #3870 fixed a duplicate auto-dispatch kwarg; neither addresses this ignored TSV flag.