fix: keep overlap category names from element 100 on - #4529
Open
jipeng6036-del wants to merge 1 commit into
Open
jipeng6036-del wants to merge 1 commit into
jipeng6036-del wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
catch_overlapping_and_nested_bboxes()labels each element as"{ix}. {category}".identify_overlapping_or_nesting_case()then dropped a fixed 3 characters to recover the category, which only matches a one-digit index.From element 100 on, leftover digits leaked into
overlapping_elementsandoverlapping_case(. Table, then0. Table). Partitioned document content was unchanged.The category is now taken from the text after the first
". ". Label construction incatch_overlapping_and_nested_bboxes()is unchanged.Tests
python -m pytest test_unstructured/test_utils.py -k overlapping -q— 11 passed (existing overlap cases plus fillers of 0 / 100 / 1000 elements)python -m ruff check unstructured/utils.py test_unstructured/test_utils.pypython -m ruff format --check unstructured/utils.py test_unstructured/test_utils.py CHANGELOG.mdgit diff --checkAI assistance was used to locate the slice and prepare the patch. The overlap cases were run locally.
Fixes #4512