can't uninstall deprecated plugin fix

binaryninjaapi.h

@@ -20915,6 +20915,7 @@ namespace BinaryNinja {
 		bool Uninstall();
 		bool CancelUninstall();
 		bool Install(std::string versionID);
+		bool MarkInstalledForMigration(std::string versionID);
 		bool InstallDependencies();
 		bool InstallDependencies(const std::string& versionID);
 		bool InstallDependencies(const std::vector<std::string>& excludedPackageNames);

binaryninjacore.h

@@ -37,7 +37,7 @@
 // Current ABI version for linking to the core. This is incremented any time
 // there are changes to the API that affect linking, including new functions,
 // new types, or modifications to existing functions or types.
-#define BN_CURRENT_CORE_ABI_VERSION 188
+#define BN_CURRENT_CORE_ABI_VERSION 189
 
 // Minimum ABI version that is supported for loading of plugins. Plugins that
 // are linked to an ABI version less than this will not be able to load and
@@ -8910,6 +8910,7 @@ extern "C"
 	BINARYNINJACOREAPI bool BNPluginEnable(BNPlugin* p, bool force);
 	BINARYNINJACOREAPI bool BNPluginDisable(BNPlugin* p);
 	BINARYNINJACOREAPI bool BNPluginInstall(BNPlugin* p, const char* versionID);
+	BINARYNINJACOREAPI bool BNPluginMarkInstalledForMigration(BNPlugin* p, const char* versionID);
 	BINARYNINJACOREAPI bool BNPluginInstallDependencies(BNPlugin* p);
 	BINARYNINJACOREAPI bool BNPluginInstallDependenciesForVersion(BNPlugin* p, const char* versionID);
 	BINARYNINJACOREAPI bool BNPluginInstallDependenciesWithExclusions(BNPlugin* p,

pluginmanager.cpp

@@ -375,6 +375,21 @@ bool Extension::Install(std::string versionID)
 }
 
 
+/* Registers a plugin as installed without downloading anything, for legacy extension migration: that path
+   adopts a plugin whose files are already on disk from the old extension manager. A real Install() there
+   would first delete those files and then need the network to fetch a replacement -- for a plugin that has
+   since been deprecated, that download is exactly the one most likely to be unavailable, which would destroy
+   a working install and leave nothing in its place. This never touches the filesystem or the network.
+   UNNECESSARY FOR USERS. */
+bool Extension::MarkInstalledForMigration(std::string versionID)
+{
+	char* versionIDStr = BNAllocString(versionID.c_str());
+	auto success = BNPluginMarkInstalledForMigration(m_object, versionIDStr);
+	BNFreeString(versionIDStr);
+	return success;
+}
+
+
 bool Extension::InstallDependencies()
 {
 	return InstallDependencies("");