Skip to content

🐞 Fix zksync forceSafeTransferETH - #1560

Merged
atarpara merged 1 commit into
mainfrom
fix-zkft
Sep 1, 2026
Merged

🐞 Fix zksync forceSafeTransferETH#1560
atarpara merged 1 commit into
mainfrom
fix-zkft

Conversation

@atarpara

Copy link
Copy Markdown
Collaborator

Description

Describe the changes made in your pull request here.

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge fmt?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

@github-actions

Copy link
Copy Markdown

Gas Snapshot Comparison Report

Generated at commit : dbb4ee2, Compared to commit : 4225d5f

Contract Name Test Name Main Gas PR Gas Diff
SafeTransferLibTest testApproveWithMissingReturn() 54380 54368 -12
testApproveWithNonContractReverts() 28465 28475 10
testApproveWithRetry() 1059830 1059818 -12
testApproveWithRetryWithNonContractReverts() 28914 28946 32
testApproveWithReturnsFalseReverts() 31998 31986 -12
testApproveWithReturnsTooLittleReverts() 31934 31944 10
testApproveWithReturnsTooMuch() 54657 54708 51
testApproveWithRevertingReverts() 31924 31923 -1
testApproveWithStandardERC20() 54306 54294 -12
testForceSafeTransferETH() 1478434 1478611 177
testTotalSupplyQuery() 59926 59842 -84
testTransferAllETHToContractWithoutFallbackReverts() 32235 32251 16
testTransferAllWithStandardERC20() 52442 52419 -23
testTransferETH() 55597 55619 22
testTransferETHToContractWithoutFallbackReverts() 32494 32510 16
testTransferFromWithMissingReturn() 632647 1127451 494804
testTransferFromWithNonContractReverts() 29897 29814 -83
testTransferFromWithReturnsFalseReverts() 641903 3594679 2952776
testTransferFromWithReturnsTooLittleReverts() 641244 624877 -16367
testTransferFromWithReturnsTooMuch() 633899 616936 -16963
testTransferFromWithRevertingReverts() 631238 614668 -16570
testTransferFromWithStandardERC20() 634250 617302 -16948
testTransferWithMissingReturn() 659619 642948 -16671
testTransferWithNonContractReverts() 28471 28481 10
testTransferWithReturnsFalseReverts() 635920 619234 -16686
testTransferWithReturnsTooLittleReverts() 635661 1314454 678793
testTransferWithReturnsTooMuch() 659307 643320 -15987
testTransferWithRevertingReverts() 635367 619289 -16078
testTransferWithStandardERC20() 659835 643226 -16609
testTryTransferAllETH() 228689 228733 44
testTryTransferETH() 228736 228692 -44
test__codesize() 39737 46218 6481
testForceSafeTransferETHPooledWithdrawalStaysSolvent() - 1068830 -
testForceSafeTransferETHToRevertingRecipient() - 740616 -
testForceSafeTransferETHWithExactRefund() - 602704 -
testForceSafeTransferETHWithPartialRefund() - 602649 -

@atarpara
atarpara merged commit 8a8c8cb into main Sep 1, 2026
14 checks passed
@atarpara
atarpara deleted the fix-zkft branch September 2, 2026 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant