-
Notifications
You must be signed in to change notification settings - Fork 1
π§ͺ Add tests for QuotePathIfNeeded #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Ven0m0
wants to merge
1
commit into
main
Choose a base branch
from
feat/test-quote-path-if-needed-1889340591394148009
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,61 @@ | ||
| #Requires AutoHotkey v2.0 | ||
| #SingleInstance Force | ||
|
|
||
| ; We only include the target file to avoid full framework initialization | ||
| #Include %A_ScriptDir%\GUI_Shared.ahk | ||
|
|
||
| ; Setup testing output | ||
| stdout := FileOpen("*", "w `n") | ||
| testsPassed := 0 | ||
| testsFailed := 0 | ||
|
|
||
| AssertEqual(expected, actual, context) { | ||
| global testsPassed, testsFailed, stdout | ||
| if (expected == actual) { | ||
| testsPassed++ | ||
| stdout.WriteLine("PASS: " . context) | ||
| } else { | ||
| testsFailed++ | ||
| stdout.WriteLine("FAIL: " . context . " - Expected '" . expected . "', but got '" . actual . "'") | ||
| } | ||
| } | ||
|
|
||
| try { | ||
| stdout.WriteLine("Starting tests for QuotePathIfNeeded...") | ||
|
|
||
| ; Test 1: Empty string | ||
| AssertEqual("", QuotePathIfNeeded(""), "Should return empty string for empty input") | ||
|
|
||
| ; Test 2: Normal path without spaces | ||
| AssertEqual("C:\path\to\file.exe", QuotePathIfNeeded("C:\path\to\file.exe"), "Should not quote path without spaces") | ||
|
|
||
| ; Test 3: Path with spaces | ||
| AssertEqual('"C:\Program Files\App\app.exe"', QuotePathIfNeeded("C:\Program Files\App\app.exe"), "Should quote path with spaces") | ||
|
|
||
| ; Test 4: Path with spaces, already fully quoted | ||
| AssertEqual('"C:\Program Files\App\app.exe"', QuotePathIfNeeded('"C:\Program Files\App\app.exe"'), "Should not double-quote an already quoted path") | ||
|
|
||
| ; Test 5: Path with spaces, quoted only at the start (edge case based on current logic) | ||
| AssertEqual('"C:\Program Files\App\app.exe', QuotePathIfNeeded('"C:\Program Files\App\app.exe'), "Should not double-quote if starting quote is present (current logic)") | ||
|
|
||
| ; Test 6: Path with spaces, quoted only at the end (edge case based on current logic) | ||
| AssertEqual('C:\Program Files\App\app.exe"', QuotePathIfNeeded('C:\Program Files\App\app.exe"'), "Should not double-quote if ending quote is present (current logic)") | ||
|
|
||
| ; Test 7: String with only spaces | ||
| AssertEqual('" "', QuotePathIfNeeded(" "), "Should quote a string containing only spaces") | ||
|
|
||
| ; Final Results | ||
| stdout.WriteLine("---") | ||
| stdout.WriteLine("Tests Passed: " . testsPassed) | ||
| stdout.WriteLine("Tests Failed: " . testsFailed) | ||
|
|
||
| } catch as e { | ||
| stdout.WriteLine("Test execution failed with error: " . e.Message) | ||
| testsFailed++ | ||
| } | ||
|
|
||
| if (testsFailed > 0) { | ||
| ExitApp(1) | ||
| } | ||
|
|
||
| ExitApp(0) | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test file uses an absolute path include. To ensure portability and maintainability as per the repository's preference for environment-aware logic, use a relative path or rely on the script's execution context without hardcoding the directory structure.
References