Skip to content

🧹 Remove unused SelectFileOrDir overload#80

Open
Ven0m0 wants to merge 1 commit intomainfrom
jules-2542981698528075050-0a72b305
Open

🧹 Remove unused SelectFileOrDir overload#80
Ven0m0 wants to merge 1 commit intomainfrom
jules-2542981698528075050-0a72b305

Conversation

@Ven0m0
Copy link
Copy Markdown
Owner

@Ven0m0 Ven0m0 commented Apr 28, 2026

🎯 What:
Removed the obsolete, single-parameter SelectFileOrDir(btn) function from Other/7zEmuPrepper/Final.ahk.

💡 Why:
The function SelectFileOrDir(btn) was fully superseded by a newer SelectFileOrDir(btn, *) overload later in the script that correctly handles parameter mismatches and correctly relies on y coordinate checking instead of global variable manipulation and partial hwnd indexing. Leaving the obsolete version in the script creates confusion and unnecessary code duplication.

Verification:

  • Analysed the single usage of SelectFileOrDir in the script, which passes (btn,*) and effectively routes to the proper SelectFileOrDir(btn, *) function.
  • Performed formatting checks ensuring DOS/CRLF (unix2dos) line endings and correct UTF-8 preservation natively.
  • Validated with git diff that no other logic or behavior was modified.
  • Simulated repository SKILL.md tests to rule out syntax breakages.

Result:
Cleaner, more maintainable code with dead code eliminated. The codebase is healthier without risking any behavior changes.


PR created automatically by Jules for task 2542981698528075050 started by @Ven0m0

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes a redundant and unused definition of the SelectFileOrDir function in Other/7zEmuPrepper/Final.ahk, consolidating the logic into a single simplified version that utilizes the control's Y position. I have no feedback to provide as there were no review comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant