Skip to content

🧹 Remove undefined function wrapper in Fullscreen.ahk #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ven0m0 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

🧹 Remove undefined function wrapper in Fullscreen.ahk #85

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions ahk/Fullscreen.ahk
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#Requires AutoHotkey v2.0

; ============================================================================
; Fullscreen.ahk - Borderless fullscreen toggle with multi-monitor support
; Fullscreen.ahk - Borderless fullscreen toggle
; Version: 2.0.0 (Migrated to AHK v2 and consolidated from 3 variants)
;
; Consolidates:
Expand All @@ -10,7 +10,7 @@
; - Fullscreen_double.ahk (separate enter/exit hotkeys)
;
; Hotkeys:
; End - Toggle borderless fullscreen (multi-monitor aware)
; End - Toggle borderless fullscreen
; Ctrl+Alt+K - Enter borderless fullscreen
; Ctrl+Alt+L - Exit and restore window
; Ctrl+Alt+End - Toggle with always-on-top
Expand All @@ -23,10 +23,10 @@ InitScript(true, true, true) ; UIA + Admin + Performance optimizations
Persistent

; ============================================================================
; Primary hotkey - End key toggles fullscreen with multi-monitor support
; Primary hotkey - End key toggles fullscreen
; ============================================================================
End:: {
ToggleFakeFullscreenMultiMonitor("A")
ToggleFakeFullscreen("A")
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot Apr 28, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Replacing ToggleFakeFullscreenMultiMonitor with ToggleFakeFullscreen introduces a functional regression by removing multi-monitor support. This also violates the Repository Style Guide (line 50), which explicitly recommends using the multi-monitor helper. Instead of downgrading this script to work around syntax errors in the library, the underlying issues in Lib/v2/WindowManager.ahk (specifically the invalid dot-notation access on Map objects like inf.style which should be inf["style"]) should be fixed to restore proper functionality across the repository.

References
  1. The style guide explicitly recommends using ToggleFakeFullscreenMultiMonitor() instead of manual window logic. (link)

}

; ============================================================================
Expand Down
Loading