Do not close an attached window because the owner answered badly - #835
Merged
Conversation
OwnerLink treated an error reply the same as a refused connection, and ViewerServer turns any exception in the owner's listing handler into an error reply. So one transient throw over there closed this window with "The queue owner is no longer running.", losing the queue it was displaying - while the owner was still running and still holding it. Only a connection that could not be made means gone now. An error reply is shown as the message it carries, and the next pass asks again.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OwnerLink treated an error reply the same as a refused connection, and ViewerServer
turns any exception in the owner's listing handler into an error reply. So one
transient throw over there closed this window with "The queue owner is no longer
running.", losing the queue it was displaying - while the owner was still running
and still holding it.
Only a connection that could not be made means gone now. An error reply is shown as
the message it carries, and the next pass asks again.