Accept all open sweeps viewer backed pairs - #862
Merged
Conversation
"Accept all open" matched a move by its live process, which is what DiffRunner records for every tool that opens one window per pair. The viewer opens none: a pair whose tool is the viewer is tracked with no process id, because it is drawn as a row in the one window every pending pair shares and so nothing may kill it. The one kind of move that is unambiguously on screen was therefore the one kind the hot key could never match, and with the viewer as the resolved tool the key looked dead. The process test predates the viewer becoming a diff tool and was not revisited then. TrackedMove now answers IsOpen for itself - the viewer, or a live process - and AcceptOpen asks that instead. Whether a tracked move is a viewer one is read off its executable name rather than through DiffTools.TryFindByPath, which is an exact path lookup: the sender resolves the copy bundled in its own DiffEngine package and a tray carries one of its own, so those two paths are never the same string. IsOpen joins the debug view, since it is the field this turned on.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"Accept all open" matched a move by its live process, which is what DiffRunner records for every tool that opens one window per pair. The viewer opens none: a pair whose tool is the viewer is tracked with no process id, because it is drawn as a row in the one window every pending pair shares and so nothing may kill it. The one kind of move that is unambiguously on screen was therefore the one kind the hot key could never match, and with the viewer as the resolved tool the key looked dead. The process test predates the viewer becoming a diff tool and was not revisited then.
TrackedMove now answers IsOpen for itself - the viewer, or a live process - and AcceptOpen asks that instead. Whether a tracked move is a viewer one is read off its executable name rather than through DiffTools.TryFindByPath, which is an exact path lookup: the sender resolves the copy bundled in its own DiffEngine package and a tray carries one of its own, so those two paths are never the same string.
IsOpen joins the debug view, since it is the field this turned on.