security: bound Sage runner resources and reference access - #3
Open
christiek673-mAth wants to merge 1 commit into
Open
security: bound Sage runner resources and reference access#3christiek673-mAth wants to merge 1 commit into
christiek673-mAth wants to merge 1 commit into
Conversation
Author
|
Hi maintainers, could you please review this PR? It adds bounded timeout/output handling and process-group cleanup to the local and WSL Sage runners, hardens bundled reference access, and documents the non-sandbox security model. Local Python 3.11 validation passed: 4 tests passed, and git diff --check passed. SageMath itself was not available in the local environment, so the resource-limit tests use Python subprocesses. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sage_ref_search.py --showfrom reading outside the bundled API reference tree.Validation
python3.11 -m unittest discover -s tests -qgit diff --checkpassed.SageMath itself was not available in the local environment, so the tests exercise the bounded executor with Python subprocesses rather than a live Sage installation.