Skip to content

Add missing sounds 1.9.4->1.8 - #128

Merged
florianreuth merged 4 commits into
ViaVersion:mainfrom
Beaness:1.9.4to1.8fixes
Sep 16, 2026
Merged

florianreuth merged 4 commits into
ViaVersion:mainfrom
Beaness:1.9.4to1.8fixes

Conversation

@Beaness

@Beaness Beaness commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Adds missing 1.9.4 -> 1.8 sounds, also removes 2 non existing 1.9.4 sound codes
Fixes ViaVersion/ViaRewind#684
Fixes ViaVersion/ViaRewind#501

Made with the help of AI to choose replacement sounds that don't exist on 1.8

@Beaness Beaness changed the title Add missing sounds Add missing sounds 1.9.4->1.8 Jun 19, 2026
@Beaness

Beaness commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

I think i've found another reason why some sounds are incorrectly translated on ViaRewind:
ViaBackwards makes sound ids go to the 1.9.0 space at https://github.com/ViaVersion/ViaBackwards/blob/59abf8bd1886cfa3ddf167453e825518496ecd86/common/src/main/java/com/viaversion/viabackwards/protocol/v1_9_1to1_9/Protocol1_9_1To1_9.java#L61
However ViaRewind uses 1.9.4 -> 1.8 mappings https://github.com/ViaVersion/ViaRewind/blob/d73c2198eabb9ada6fa98d6343b7d8cb8b8c05e2/common/src/main/java/com/viaversion/viarewind/protocol/v1_9to1_8/Protocol1_9To1_8.java#L64
for sound translation

Which means every sound >= 415 (item.elytra.flying) gets translated to the wrong sound (off by one)
and explains the following issue: ViaVersion/ViaRewind#682
A more proper fix is probably generating 1.9->1.8 mappings instead and using that in ViaRewind

@Beaness

Beaness commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Latest commit on this PR changes mappings to be 1.9 -> 1.8 so ViaRewind uses the proper identifiers for sounds

@florianreuth
florianreuth requested review from florianreuth and removed request for florianreuth June 20, 2026 14:06
@florianreuth florianreuth self-assigned this Jun 20, 2026
# Conflicts:
#	mappings/diff/mapping-1.9to1.8.json
#	output_hashes.json
@florianreuth
florianreuth merged commit bb1b69a into ViaVersion:main Sep 16, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sound Issues Sounds are not properly translated in 1.8->1.9

2 participants