Repository navigation
fix(auth): preserve Basic query permissions during browser login - #56
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Browser login with the same credentials as an in-flight Basic-auth query could remove that query's cached session between middleware authorization and the handler's permission lookup. The query then returned
User does not have access to streamdespite valid credentials.Keep the credential-keyed Basic session when issuing the browser cookie. Password changes and deletion still invalidate both tracked sessions; role changes still refresh both. Cookie logout and expiration remain session-specific.
Validation:
rbac::lock_order_testspass using the full native Rust test target.oidc.rsonc5e1e08fbecause the Basic session disappears, and passes with this fix.git diff --checkpass.This fixes the transient authorization failure discovered during PR #55 validation. Staging conversion visibility and Parquet-file lifetime are separate fixes; no Prism/UI changes are included.
Need help on this PR? Tag
@codesmith-botwith what you need.