Repository navigation
Remove the multi-file Scala.js linked output directory recursively - #4549
Merged
Gedochao merged 1 commit intoOct 16, 2026
Merged
Conversation
sideeffffect
marked this pull request as ready for review
October 13, 2026 20:09
Contributor
|
note: please fill our PR template when contributing. |
4 tasks done
With the Wasm backend (or JS module splitting) the linker emits several files, so Package.linkJs turns the temporary destination into a directory. The cleanup used os.remove, which throws DirectoryNotEmptyException: `scala-cli test --js-emit-wasm` exited 1 after all tests passed, and `run` leaked the directory. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Gedochao
force-pushed
the
fix/js-linked-output-dir-cleanup
branch
from
October 15, 2026 15:22
d984dbf to
36c94e8
Compare
Contributor
|
(rebased) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This comes up with more complex Scala Wasm setups.