Repository navigation
Add --js-wasm-jspi and //> using wasmJspi to enable JSPI on Wasm - #4550
Open
sideeffffect wants to merge 6 commits into
Open
sideeffffect wants to merge 6 commits into
sideeffffect wants to merge 6 commits into
Conversation
Since Scala.js 1.22 the linker links js.async/js.await on WebAssembly only when WasmFeatures.useJSPI is set; otherwise linking fails with "Uses an async block without JSPI support in WebAssembly". The option is passed to the Scala.js CLI as --useJSPI, which needs a Scala.js CLI release containing VirtusLab/scala-js-cli#209. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sideeffffect
marked this pull request as ready for review
October 13, 2026 20:15
Contributor
|
note: please fill our PR template when contributing. |
Contributor
|
Also, it seems the new test is failing. |
Gedochao
marked this pull request as draft
October 15, 2026 08:29
…s --useJSPI The bundled scala-js-cli (1.22.0.1) rejects --useJSPI, so the end-to-end test can only pass once VirtusLab/scala-js-cli#209 is released and scalaJsCli is bumped. The option parsing and directive are covered by unit tests. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Gedochao
reviewed
Oct 16, 2026
Skip it on Scala 3.3, whose compiler has no js.async/js.await support. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
sideeffffect
marked this pull request as ready for review
October 16, 2026 13:53
Contributor
Author
|
@Gedochao should be mergable now 👍 |
Gedochao
reviewed
Oct 19, 2026
…alaJsTestDefinitions.scala Co-authored-by: Piotr Chabelski <ged.subfan@gmail.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed when playing with Scala Wasm via scala-cli.