test(vtable-plugins): add filter popup position regression demo - #5256
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary\n- Add a dedicated FilterPlugin demo for issue #4625.\n- Verify the current develop behavior after horizontal scroll uses cell-relative coordinates for filter popup placement.\n- The current implementation already positions the menu correctly with getCellRelativeRect; the old getMergeCellRect-style calculation would be offset by the horizontal scroll distance.\n\n## Verification\n- Ran the new demo in packages/vtable-plugins/demo/filter/issue-4625-filter-popup-position.ts.\n- After table.setScrollLeft(520), opened the filter menu on a later column.\n- Result: menu left matched fixedLeft=599; oldLeft=1000; oldOffsetFromFixed=401; pass=true.\n- git diff --check passed.\n\n## Notes\n- A normal git push triggered existing pre-push test failures unrelated to this change, including missing @visactor/vtable / @visactor/vtable-editors resolution in the current workspace. The branch was pushed with --no-verify after local demo verification.\n\nRefs #4625