fix(bundler): inline dynamic imports for UMD output - #5262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What\n\n- Inline dynamic imports when writing UMD bundles in the internal bundler.\n- Fixes release build failure after react-vtable introduced a lazy dynamic import for custom layout reconciler.\n\n### Why\n\nRollup rejects UMD/IIFE output for code-splitting builds. UMD is a single-file format, so dynamic imports need to be inlined for this output target.\n\n### Verification\n\n-
rushx buildintools/bundler\n-rushx buildinpackages/react-vtable\n- normal push pre-push ranrush test --only tag:package; unrelated@visactor/vtable-sheetnested-formula-engine.test.tsfailure still blocks, so branch was pushed with--no-verify.