fix(looks-same): expose native diff percentage - #354
Open
Octember wants to merge 7 commits into
Open
Conversation
pashidlos
requested changes
Jul 28, 2026
pashidlos
left a comment
Member
There was a problem hiding this comment.
Bugbot found 1 issue on PR #354 (Bugbot).
| Severity | Location (file:line) | Finding |
|---|---|---|
| high | src/compare/libs/looks-same/looks-same.service.ts:87 |
createDiff no longer swallows looksSame errors and throws on equal: true. calculateDiff deletes the old diff file before getDiff, so a throw skips saveDiffResult and can leave a stale diffName pointing at a removed file. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
createDiffImageoutputdifferentPixels / totalPixelsasdiffPercentalongside that artifactWhy
Looks-Same already calculates
differentPixelsandtotalPixelswhile producing a diff image. VRT currently discards those metrics, so unresolved comparisons displayDiff: 0%. The metrics stay strictly in the existingsaveDiffAsFilepath: ordinary comparisons do not allocate a diff image or change behavior.Verification
npm test -- --runInBand src/compare/libs/looks-same/looks-same.service.spec.tsnpm run buildSummary by CodeRabbit