Skip to content

fix(Odiff): this.hddService.generateNewImage is not a function - #357

Open
mokhtardziri wants to merge 3 commits into
Visual-Regression-Tracker:masterfrom
mokhtardziri:customizations
Open

fix(Odiff): this.hddService.generateNewImage is not a function#357
mokhtardziri wants to merge 3 commits into
Visual-Regression-Tracker:masterfrom
mokhtardziri:customizations

Conversation

@mokhtardziri

@mokhtardziri mokhtardziri commented Jul 28, 2026

Copy link
Copy Markdown

Summary by CodeRabbit

  • Refactor

    • Improved service dependency injection and module wiring for more reliable application behavior.
    • Updated internal service integration without changing user-facing functionality.
  • Tests

    • Updated test setup to provide the required service dependency and align import usage.

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: d71d521f-a395-4b5e-ab15-9933b0859b71

📥 Commits

Reviewing files that changed from the base of the PR and between e583e5a and d689cbc.

📒 Files selected for processing (4)
  • src/compare/libs/odiff/odiff.service.spec.ts
  • src/compare/libs/odiff/odiff.service.ts
  • src/static/hdd/hdd.service.ts
  • src/static/static.module.ts

📝 Walkthrough

Walkthrough

HddService is registered as an injectable provider and exported by StaticModule. OdiffService now receives it through NestJS dependency injection, and its test module supplies a corresponding mock.

Changes

Odiff HddService injection

Layer / File(s) Summary
HddService module wiring
src/static/hdd/hdd.service.ts, src/static/static.module.ts
HddService is decorated with @Injectable(), registered in StaticModule, and exported from the module.
OdiffService injection integration
src/compare/libs/odiff/odiff.service.ts, src/compare/libs/odiff/odiff.service.spec.ts
OdiffService injects HddService directly, and the test setup provides a mocked instance with updated relative imports.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the fix: OdiffService now injects HddService correctly to resolve the generateNewImage error.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.


Comment @coderabbitai help to get the list of available commands.

@pashidlos pashidlos left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants